Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Side by Side Diff: chrome/browser/sync/test/integration/bookmarks_helper.h

Issue 2494633005: Revert of [sync] "TwoClientBookmarksSyncTest.Sanity" is flaky (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/bookmarks_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_ 5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_
6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_ 6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 217
218 } // namespace bookmarks_helper 218 } // namespace bookmarks_helper
219 219
220 // Checker used to block until bookmarks match on all clients. 220 // Checker used to block until bookmarks match on all clients.
221 class BookmarksMatchChecker : public MultiClientStatusChangeChecker { 221 class BookmarksMatchChecker : public MultiClientStatusChangeChecker {
222 public: 222 public:
223 BookmarksMatchChecker(); 223 BookmarksMatchChecker();
224 224
225 // StatusChangeChecker implementation. 225 // StatusChangeChecker implementation.
226 bool IsExitConditionSatisfied() override; 226 bool IsExitConditionSatisfied() override;
227 std::string GetDebugMessage() const override;
228 };
229
230 // Checker used to block until bookmarks match the verifier bookmark model.
231 class BookmarksMatchVerifierChecker : public MultiClientStatusChangeChecker {
232 public:
233 BookmarksMatchVerifierChecker();
234
235 // StatusChangeChecker implementation.
236 bool IsExitConditionSatisfied() override;
237 std::string GetDebugMessage() const override; 227 std::string GetDebugMessage() const override;
238 }; 228 };
239 229
240 // Checker used to block until the actual number of bookmarks with the given 230 // Checker used to block until the actual number of bookmarks with the given
241 // title match the expected count. 231 // title match the expected count.
242 // TODO(pvalenzuela): Remove this class and instead use 232 // TODO(pvalenzuela): Remove this class and instead use
243 // AwaitMatchStatusChangeChecker. 233 // AwaitMatchStatusChangeChecker.
244 class BookmarksTitleChecker : public SingleClientStatusChangeChecker { 234 class BookmarksTitleChecker : public SingleClientStatusChangeChecker {
245 public: 235 public:
246 BookmarksTitleChecker(int profile_index, 236 BookmarksTitleChecker(int profile_index,
(...skipping 11 matching lines...) Expand all
258 }; 248 };
259 249
260 // Checker used to block until the actual number of bookmarks with the given url 250 // Checker used to block until the actual number of bookmarks with the given url
261 // match the expected count. 251 // match the expected count.
262 class BookmarksUrlChecker : public AwaitMatchStatusChangeChecker { 252 class BookmarksUrlChecker : public AwaitMatchStatusChangeChecker {
263 public: 253 public:
264 BookmarksUrlChecker(int profile, const GURL& url, int expected_count); 254 BookmarksUrlChecker(int profile, const GURL& url, int expected_count);
265 }; 255 };
266 256
267 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_ 257 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_BOOKMARKS_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/bookmarks_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698