Remove about:srcdoc url conversion.

content/browser/frame_host/navigator_impl.cc

Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 5740af67acbee9231ed9620e601cc8be1848aa9a..d76d5d6bf7f979b48083fb9079ebc7ce05a0e8ba 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -146,10 +146,10 @@ void NavigatorImpl::DidStartProvisionalLoad(
     const base::TimeTicks& navigation_start) {
   bool is_main_frame = render_frame_host->frame_tree_node()->IsMainFrame();
   bool is_error_page = (url.spec() == kUnreachableWebDataURL);
-  bool is_iframe_srcdoc = (url.spec() == kAboutSrcDocURL);
   GURL validated_url(url);
   RenderProcessHost* render_process_host = render_frame_host->GetProcess();
-  render_process_host->FilterURL(false, &validated_url);
+  if (validated_url != GURL(content::kAboutSrcDocURL))

[nasko, 2016/11/10 18:14:14]

This doesn't strike me as a good practice. We don't want to special case srcdoc
everywhere we call FilterURL. Why not update FilterURL with knowledge about
srcdoc?

[Charlie Reis, 2016/11/11 22:53:24]

Agreed.

[arthursonzogni, 2016/11/15 16:37:09]

I agree, but do you think it is careful to modify the FilterURL function? It is
also used in a lot of different places (28 occurences). I only have identified 3
places where the about:srcdoc needs to be kept.
I will make the change and check the test results of the bots.

[Charlie Reis, 2016/11/16 18:20:22]

Yes, I think it's fine to allow about:srcdoc through in all cases.  I don't
think we were thinking about that case when canonicalizing about:anything to
about:blank.

+    render_process_host->FilterURL(false, &validated_url);
 
   // Do not allow browser plugin guests to navigate to non-web URLs, since they
   // cannot swap processes or grant bindings.
@@ -169,7 +169,7 @@ void NavigatorImpl::DidStartProvisionalLoad(
   if (delegate_) {
     // Notify the observer about the start of the provisional load.
     delegate_->DidStartProvisionalLoad(render_frame_host, validated_url,
-                                       is_error_page, is_iframe_srcdoc);
+                                       is_error_page);
   }
 
   if (is_error_page || IsBrowserSideNavigationEnabled())
@@ -208,7 +208,6 @@ void NavigatorImpl::DidStartProvisionalLoad(
       validated_url, render_frame_host->frame_tree_node(),
       is_renderer_initiated,
       false,             // is_same_page
-      is_iframe_srcdoc,  // is_srcdoc
       navigation_start, pending_nav_entry_id, started_from_context_menu));
 }