Remove about:srcdoc url conversion.

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 128 matching lines @@
 NavigationController* NavigatorImpl::GetController() {
   return controller_;
 }
 
 void NavigatorImpl::DidStartProvisionalLoad(
     RenderFrameHostImpl* render_frame_host,
     const GURL& url,
     const base::TimeTicks& navigation_start) {
   bool is_main_frame = render_frame_host->frame_tree_node()->IsMainFrame();
   bool is_error_page = (url.spec() == kUnreachableWebDataURL);
-  bool is_iframe_srcdoc = (url.spec() == kAboutSrcDocURL);
   GURL validated_url(url);
   RenderProcessHost* render_process_host = render_frame_host->GetProcess();
-  render_process_host->FilterURL(false, &validated_url);
+  if (validated_url != GURL(content::kAboutSrcDocURL))

[nasko, 2016/11/10 18:14:14]

This doesn't strike me as a good practice. We don't want to special case srcdoc
everywhere we call FilterURL. Why not update FilterURL with knowledge about
srcdoc?

[Charlie Reis, 2016/11/11 22:53:24]

Agreed.

[arthursonzogni, 2016/11/15 16:37:09]

I agree, but do you think it is careful to modify the FilterURL function? It is
also used in a lot of different places (28 occurences). I only have identified 3
places where the about:srcdoc needs to be kept.
I will make the change and check the test results of the bots.

[Charlie Reis, 2016/11/16 18:20:22]

Yes, I think it's fine to allow about:srcdoc through in all cases.  I don't
think we were thinking about that case when canonicalizing about:anything to
about:blank.

+    render_process_host->FilterURL(false, &validated_url);
 
   // Do not allow browser plugin guests to navigate to non-web URLs, since they
   // cannot swap processes or grant bindings.
   ChildProcessSecurityPolicyImpl* policy =
       ChildProcessSecurityPolicyImpl::GetInstance();
   if (render_process_host->IsForGuestsOnly() &&
       !policy->IsWebSafeScheme(validated_url.scheme())) {
     validated_url = GURL(url::kAboutBlankURL);
   }
 
   if (is_main_frame && !is_error_page) {
     DidStartMainFrameNavigation(validated_url,
                                 render_frame_host->GetSiteInstance(),
                                 render_frame_host->navigation_handle());
   }
 
   if (delegate_) {
     // Notify the observer about the start of the provisional load.
     delegate_->DidStartProvisionalLoad(render_frame_host, validated_url,
-                                       is_error_page, is_iframe_srcdoc);
+                                       is_error_page);
   }
 
   if (is_error_page || IsBrowserSideNavigationEnabled())
     return;
 
   if (render_frame_host->navigation_handle()) {
     if (render_frame_host->navigation_handle()->is_transferring()) {
       // If the navigation is completing a transfer, this
       // DidStartProvisionalLoad should not correspond to a new navigation.
       DCHECK_EQ(url, render_frame_host->navigation_handle()->GetURL());
@@ skipping 18 matching lines @@
   if (pending_entry) {
     is_renderer_initiated = pending_entry->is_renderer_initiated();
     pending_nav_entry_id = pending_entry->GetUniqueID();
     started_from_context_menu = pending_entry->has_started_from_context_menu();
   }
 
   render_frame_host->SetNavigationHandle(NavigationHandleImpl::Create(
       validated_url, render_frame_host->frame_tree_node(),
       is_renderer_initiated,
       false,             // is_same_page
-      is_iframe_srcdoc,  // is_srcdoc
       navigation_start, pending_nav_entry_id, started_from_context_menu));
 }
 
 void NavigatorImpl::DidFailProvisionalLoadWithError(
     RenderFrameHostImpl* render_frame_host,
     const FrameHostMsg_DidFailProvisionalLoadWithError_Params& params) {
   VLOG(1) << "Failed Provisional Load: " << params.url.possibly_invalid_spec()
           << ", error_code: " << params.error_code
           << ", error_description: " << params.error_description
           << ", showing_repost_interstitial: " <<
@@ skipping 1042 matching lines @@
     if (navigation_handle)
       navigation_handle->update_entry_id_for_transfer(entry->GetUniqueID());
 
     controller_->SetPendingEntry(std::move(entry));
     if (delegate_)
       delegate_->NotifyChangedNavigationState(content::INVALIDATE_TYPE_URL);
   }
 }
 
 }  // namespace content