Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issue 2494623002: cc: Remove client/engine LayerTreeHostInProcess. (Closed)

Created:
4 years, 1 month ago by Khushal
Modified:
4 years, 1 month ago
Reviewers:
ajuma, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove client/engine LayerTreeHostInProcess. Remove all unused code in LayerTreeHostInProcess for the remote mode. All code for this is now in cc/blimp, so this removes the code for the deprecated path. Clean up for proto conversion code is going to be in a subsequent patch. BUG=648442 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753 Cr-Commit-Position: refs/heads/master@{#431772}

Patch Set 1 #

Patch Set 2 : test fixed. #

Patch Set 3 : Rebase #

Patch Set 4 : test #

Patch Set 5 : rebase #

Patch Set 6 : missed removing the other channel #

Patch Set 7 : move RemoteProtoChannel #

Patch Set 8 : blimp test #

Patch Set 9 : Rebase #

Patch Set 10 : good rebase #

Patch Set 11 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+616 lines, -2408 lines) Patch
M blimp/client/core/compositor/blimp_compositor.h View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M blimp/engine/renderer/blimp_content_renderer_client.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/renderer/blimp_content_renderer_client.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/renderer/blimp_remote_compositor_bridge.h View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
M blimp/engine/renderer/blimp_remote_compositor_bridge.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M blimp/engine/renderer/blimp_remote_compositor_bridge_unittest.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M cc/BUILD.gn View 1 2 3 4 5 6 7 8 4 chunks +5 lines, -9 lines 0 comments Download
M cc/blimp/compositor_state_deserializer_unittest.cc View 3 chunks +7 lines, -230 lines 0 comments Download
A cc/blimp/layer_tree_host_unittest_serialization.cc View 1 2 3 1 chunk +174 lines, -0 lines 0 comments Download
M cc/test/fake_layer_tree_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_host_remote_for_testing.cc View 1 chunk +6 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +0 lines, -1 line 0 comments Download
A cc/test/remote_compositor_test.h View 1 chunk +63 lines, -0 lines 0 comments Download
A cc/test/remote_compositor_test.cc View 1 chunk +120 lines, -0 lines 0 comments Download
D cc/test/remote_proto_channel_bridge.h View 1 chunk +0 lines, -62 lines 0 comments Download
D cc/test/remote_proto_channel_bridge.cc View 1 chunk +0 lines, -72 lines 0 comments Download
A cc/test/serialization_test_utils.h View 1 chunk +27 lines, -0 lines 0 comments Download
A cc/test/serialization_test_utils.cc View 1 chunk +167 lines, -0 lines 0 comments Download
M cc/trees/layer_tree.h View 3 chunks +7 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.h View 1 2 3 4 5 chunks +0 lines, -43 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.cc View 1 2 3 4 10 chunks +3 lines, -232 lines 0 comments Download
D cc/trees/layer_tree_host_unittest_remote_server.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D cc/trees/layer_tree_host_unittest_serialization.cc View 1 chunk +0 lines, -453 lines 0 comments Download
M cc/trees/proxy_main.h View 1 2 3 4 2 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/proxy_main.cc View 1 2 3 4 3 chunks +1 line, -13 lines 0 comments Download
D cc/trees/remote_channel_impl.h View 1 2 3 4 5 1 chunk +0 lines, -208 lines 0 comments Download
D cc/trees/remote_channel_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -520 lines 0 comments Download
D cc/trees/remote_channel_main.h View 1 chunk +0 lines, -91 lines 0 comments Download
D cc/trees/remote_channel_main.cc View 1 chunk +0 lines, -278 lines 0 comments Download
D cc/trees/remote_proto_channel.h View 1 2 3 4 5 6 1 chunk +0 lines, -47 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 2 3 4 5 6 3 chunks +2 lines, -2 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + content/public/renderer/remote_proto_channel.h View 1 2 3 4 5 6 2 chunks +16 lines, -14 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 4 5 6 7 8 10 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 55 (42 generated)
Khushal
4 years, 1 month ago (2016-11-10 01:28:41 UTC) #4
ajuma
Thanks! lgtm
4 years, 1 month ago (2016-11-10 15:42:13 UTC) #21
Khushal
+piman. Could you take a look at the RemoteProtoChannel move. It's not used in cc ...
4 years, 1 month ago (2016-11-10 20:38:48 UTC) #25
Khushal
On 2016/11/10 20:38:48, Khushal wrote: > +piman. Could you take a look at the RemoteProtoChannel ...
4 years, 1 month ago (2016-11-11 18:17:51 UTC) #37
piman
sorry for delay, LGTM
4 years, 1 month ago (2016-11-12 00:01:21 UTC) #38
Khushal
On 2016/11/12 00:01:21, piman wrote: > sorry for delay, LGTM Thanks!
4 years, 1 month ago (2016-11-12 00:09:07 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494623002/140001
4 years, 1 month ago (2016-11-12 00:10:07 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/163072) blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-12 00:15:06 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494623002/200001
4 years, 1 month ago (2016-11-12 00:33:18 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-12 02:34:28 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494623002/200001
4 years, 1 month ago (2016-11-12 02:37:08 UTC) #51
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 1 month ago (2016-11-12 04:44:36 UTC) #53
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 04:46:44 UTC) #55
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/c7eae9db07da0e2198fd95936046d719c7e78753
Cr-Commit-Position: refs/heads/master@{#431772}

Powered by Google App Engine
This is Rietveld 408576698