Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2493523003: cc: Remove unused proto conversion code. (Closed)

Created:
4 years, 1 month ago by Khushal
Modified:
4 years, 1 month ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove unused proto conversion code. This removes the unused proto conversion code from layers and updates the tests. BUG=648442 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748 Cr-Commit-Position: refs/heads/master@{#431779}

Patch Set 1 #

Patch Set 2 : and tests. #

Patch Set 3 : test updated #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : test fix #

Patch Set 7 : Rebase #

Patch Set 8 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+415 lines, -2354 lines) Patch
M blimp/client/test/compositor/blimp_compositor_with_fake_host.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/BUILD.gn View 1 2 3 4 2 chunks +0 lines, -3 lines 0 comments Download
M cc/blimp/layer_tree_host_remote.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M cc/blimp/layer_tree_host_unittest_serialization.cc View 1 2 3 4 5 5 chunks +252 lines, -14 lines 0 comments Download
M cc/layers/layer.h View 1 3 chunks +3 lines, -39 lines 0 comments Download
M cc/layers/layer.cc View 1 2 3 4 3 chunks +1 line, -234 lines 0 comments Download
D cc/layers/layer_proto_converter.h View 1 chunk +0 lines, -76 lines 0 comments Download
D cc/layers/layer_proto_converter.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D cc/layers/layer_proto_converter_unittest.cc View 1 1 chunk +0 lines, -386 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 2 3 4 3 chunks +0 lines, -1068 lines 0 comments Download
M cc/layers/picture_layer.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M cc/layers/picture_layer.cc View 2 chunks +2 lines, -56 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 1 chunk +0 lines, -192 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.h View 1 2 chunks +12 lines, -3 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M cc/playback/recording_source.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_remote_compositor_bridge.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cc/test/fake_remote_compositor_bridge.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M cc/test/push_properties_counting_layer.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/push_properties_counting_layer.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M cc/test/remote_compositor_test.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M cc/test/remote_compositor_test.cc View 1 3 chunks +9 lines, -1 line 0 comments Download
M cc/test/serialization_test_utils.h View 1 2 chunks +10 lines, -1 line 0 comments Download
M cc/test/serialization_test_utils.cc View 1 4 chunks +92 lines, -3 lines 0 comments Download
M cc/trees/layer_tree.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M cc/trees/layer_tree.cc View 4 chunks +1 line, -114 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
Khushal
Still need to update the tests.
4 years, 1 month ago (2016-11-10 02:36:31 UTC) #3
ajuma
On 2016/11/10 02:36:31, Khushal wrote: > Still need to update the tests. Thanks for cleaning ...
4 years, 1 month ago (2016-11-10 15:51:17 UTC) #4
Khushal
and tests updated.
4 years, 1 month ago (2016-11-10 18:36:35 UTC) #5
ajuma
On 2016/11/10 18:36:35, Khushal wrote: > and tests updated. lgtm
4 years, 1 month ago (2016-11-10 22:27:38 UTC) #10
Khushal
Because we are still re-syncing the hierarchy for each update, push properties on the client ...
4 years, 1 month ago (2016-11-12 01:02:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493523003/100001
4 years, 1 month ago (2016-11-12 04:45:58 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/334196)
4 years, 1 month ago (2016-11-12 04:48:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493523003/120001
4 years, 1 month ago (2016-11-12 05:01:44 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/163199) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-12 05:18:37 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493523003/140001
4 years, 1 month ago (2016-11-12 05:28:37 UTC) #25
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 1 month ago (2016-11-12 07:52:39 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 07:54:39 UTC) #29
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/bb82c56db89fe47dc93b3fc59294bf61e7e82748
Cr-Commit-Position: refs/heads/master@{#431779}

Powered by Google App Engine
This is Rietveld 408576698