Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1960)

Issue 249453002: First step in pulling SkPicturePlayback & SkPictureRecord out of SkPicture (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

First step in pulling SkPicturePlayback & SkPictureRecord out of SkPicture This CL begins the process of making SkPicturePlayback & SkPictureRecord independent of SkPicture. It just moves the PathHeap into SkPicture to get a feel for where all this is going to lead. Some items of note: SkTimedPicture (debugger/QT) should wind up being just an SkPicturePlayback-derived object. All the flattening & unflattening should migrate out of SkPicturePlayback and into SkPicture. SkPicture::initForPlayback should eventually become something just SkPictureRecorder::endRecording calls. SkPicture is passed into SkPicturePlayback's & SkPictureRecord's constructors. SkPicturePlayback only holds onto a "const SkPicture*". The SkPicturePlayback:: CreateFromStream & CreateFromBuffer methods pass a non-const SkPicture* down the call stack. BUG=skia:2315 Committed: http://code.google.com/p/skia/source/detail?r=14341

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -118 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 2 chunks +15 lines, -10 lines 0 comments Download
M include/core/SkPicture.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/core/SkBBoxHierarchyRecord.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkBBoxHierarchyRecord.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/core/SkBBoxRecord.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkPicture.cpp View 11 chunks +97 lines, -19 lines 0 comments Download
M src/core/SkPicturePlayback.h View 1 5 chunks +22 lines, -11 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 18 chunks +48 lines, -59 lines 0 comments Download
M src/core/SkPictureRecord.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 4 chunks +3 lines, -11 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 8 months ago (2014-04-23 15:23:31 UTC) #1
reed1
lgtm
6 years, 8 months ago (2014-04-23 17:07:39 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-23 21:21:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/249453002/20001
6 years, 8 months ago (2014-04-23 21:21:27 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 22:35:48 UTC) #5
Message was sent while issue was closed.
Change committed as 14341

Powered by Google App Engine
This is Rietveld 408576698