Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2494523002: Revert of added constant folding & branch elimination to skslc (Closed)

Created:
4 years, 1 month ago by scroggo
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of added constant folding & branch elimination to skslc (patchset #3 id:40001 of https://codereview.chromium.org/2489673002/ ) Reason for revert: Breaking the DEPS roll: ../../third_party/skia/src/sksl/SkSLIRGenerator.cpp:257:70: error: chosen constructor is explicit in copy-initialization return std::unique_ptr<Statement>(new Block(s.fPosition, { }, fSymbolTable)); ^~~ ../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/vector:77:7: note: constructor declared here vector(const _Allocator& __a = _Allocator()) ^ ../../third_party/skia/src/sksl/ir/SkSLBlock.h:20:70: note: passing argument to parameter 'statements' here Block(Position position, std::vector<std::unique_ptr<Statement>> statements, ^ Original issue's description: > added constant folding & branch elimination to skslc > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2489673002 > > Committed: https://skia.googlesource.com/skia/+/6136310ee8f43247548bcefcaeca6d43023c10aa TBR=benjaminwagner@google.com,bsalomon@google.com,ethannicholas@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/6e4b594b545134588e982f219d96067972cc166c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -227 lines) Patch
M src/sksl/SkSLIRGenerator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/sksl/SkSLIRGenerator.cpp View 5 chunks +5 lines, -105 lines 0 comments Download
M tests/SkSLErrorTest.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M tests/SkSLGLSLTest.cpp View 5 chunks +4 lines, -101 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scroggo
Created Revert of added constant folding & branch elimination to skslc
4 years, 1 month ago (2016-11-09 20:03:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494523002/1
4 years, 1 month ago (2016-11-09 20:03:11 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 20:03:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6e4b594b545134588e982f219d96067972cc166c

Powered by Google App Engine
This is Rietveld 408576698