Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: tests/SkSLErrorTest.cpp

Issue 2494523002: Revert of added constant folding & branch elimination to skslc (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/sksl/SkSLIRGenerator.cpp ('k') | tests/SkSLGLSLTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/SkSLErrorTest.cpp
diff --git a/tests/SkSLErrorTest.cpp b/tests/SkSLErrorTest.cpp
index fc20fa2e6d03a79e60f16be096f7716bba90ef09..9e89b71473ab5f3c56aa0238240b2781e232e724 100644
--- a/tests/SkSLErrorTest.cpp
+++ b/tests/SkSLErrorTest.cpp
@@ -352,19 +352,3 @@
"void foo() { for(;;); continue; }",
"error: 1: continue statement must be inside a loop\n1 error\n");
}
-
-DEF_TEST(SkSLStaticIfError, r) {
- // ensure eliminated branch of static if / ternary is still checked for errors
- test_failure(r,
- "void foo() { if (true); else x = 5; }",
- "error: 1: unknown identifier 'x'\n1 error\n");
- test_failure(r,
- "void foo() { if (false) x = 5; }",
- "error: 1: unknown identifier 'x'\n1 error\n");
- test_failure(r,
- "void foo() { true ? 5 : x; }",
- "error: 1: unknown identifier 'x'\n1 error\n");
- test_failure(r,
- "void foo() { false ? x : 5; }",
- "error: 1: unknown identifier 'x'\n1 error\n");
-}
« no previous file with comments | « src/sksl/SkSLIRGenerator.cpp ('k') | tests/SkSLGLSLTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698