Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2494373002: Remove IPC channel IDs. (Closed)

Created:
4 years, 1 month ago by Sam McNally
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IPC channel IDs. Channel IDs are now always empty. This CL removes them entirely. BUG=659448 Committed: https://crrev.com/a1b3b4d39c4de0bf2aee5ee20ac7d321a3d37eed Cr-Commit-Position: refs/heads/master@{#432020}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -33 lines) Patch
M content/common/child_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/ipc_channel_mojo.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_proxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M ipc/ipc_logging.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ipc/ipc_logging.cc View 7 chunks +6 lines, -11 lines 0 comments Download
M ipc/ipc_message_utils.h View 2 chunks +4 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (10 generated)
Sam McNally
4 years, 1 month ago (2016-11-14 00:43:58 UTC) #7
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-11-14 18:10:29 UTC) #8
Sam McNally
+piman for //content
4 years, 1 month ago (2016-11-14 22:50:39 UTC) #10
piman
lgtm
4 years, 1 month ago (2016-11-14 23:02:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494373002/20001
4 years, 1 month ago (2016-11-14 23:06:29 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 00:35:12 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:39:55 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1b3b4d39c4de0bf2aee5ee20ac7d321a3d37eed
Cr-Commit-Position: refs/heads/master@{#432020}

Powered by Google App Engine
This is Rietveld 408576698