Remove unused parts of IPC::ChannelHandle.

Remove unused parts of IPC::ChannelHandle.

In SFI NaCl, ChannelHandle is just a file descriptor. On other platforms
it's just a mojo message pipe handle. This CL removes the other unused
fields. It also removes IPC::Channel::GenerateMojoChannelHandlePair()
and updates its remaining use.

BUG=659448
Committed: https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024
Cr-Commit-Position: refs/heads/master@{#431821}

[Sam McNally, 2016-11-08 22:24:20]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 22:24:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 22:47:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 22:47:47]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Sam McNally, 2016-11-09 00:09:42]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 00:10:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 00:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 00:13:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sam McNally, 2016-11-09 00:33:10]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 00:33:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 01:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 01:01:16]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sam McNally, 2016-11-09 03:54:26]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 03:54:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-09 04:05:00]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-11-09 04:05:02]

Patchset #4 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-11-09 04:05:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-09 07:31:41]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-11-09 07:31:53]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-11-09 07:31:56]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-11-09 07:31:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-09 07:31:59]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-11-09 07:32:15]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-11-09 07:32:44]

Patchset #1 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-11-09 08:24:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 08:24:57]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-09 08:53:54]

sammc@chromium.org changed reviewers:
+ boliu@chromium.org, raymes@chromium.org, sky@chromium.org, tsepez@chromium.org

[Sam McNally, 2016-11-09 08:53:55]

+sky for //chrome

+raymes for //ppapi

+boliu for //android_webview

+tsepez for //ipc and //tools/ipc_fuzzer

[sky, 2016-11-09 16:25:25]

https://codereview.chromium.org/2484943004/diff/120001/chrome/browser/printin...
File chrome/browser/printing/printing_message_filter.h (right):

https://codereview.chromium.org/2484943004/diff/120001/chrome/browser/printin...
chrome/browser/printing/printing_message_filter.h:19: #if defined(OS_CHROMEOS)
|| defined(OS_ANDROID)
How come you need OS_CHROMEOS here? AFAICT it's only OS_ANDROID that uses
base::FD here. Additionally can you forward declare base::FileDescriptor for
android?

[boliu, 2016-11-09 17:36:55]

a_w lgtm

[Tom Sepez, 2016-11-09 17:40:06]

Pls. manually check that you can build the target ipc_fuzzer_all

LGTM otherwise.

[Sam McNally, 2016-11-09 20:27:50]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 20:28:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-11-09 20:54:58]

On 2016/11/09 17:40:06, Tom Sepez wrote:
> Pls. manually check that you can build the target ipc_fuzzer_all

Done.

https://codereview.chromium.org/2484943004/diff/120001/chrome/browser/printin...
File chrome/browser/printing/printing_message_filter.h (right):

https://codereview.chromium.org/2484943004/diff/120001/chrome/browser/printin...
chrome/browser/printing/printing_message_filter.h:19: #if defined(OS_CHROMEOS)
|| defined(OS_ANDROID)
On 2016/11/09 16:25:25, sky wrote:
> How come you need OS_CHROMEOS here? AFAICT it's only OS_ANDROID that uses
> base::FD here. Additionally can you forward declare base::FileDescriptor for
> android?

Done.

[commit-bot: I haz the power, 2016-11-09 22:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 22:14:32]

Dry run: This issue passed the CQ dry run.

[sky, 2016-11-09 23:10:18]

LGTM

[raymes, 2016-11-14 00:46:07]

ppapi lgtm

[Sam McNally, 2016-11-14 00:48:24]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-11-14 00:48:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2484943004/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-11-14 00:48:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 01:47:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 01:47:50]

Failed to apply patch for ipc/ipc_channel.h:
While running git apply --index -p1;
  error: patch failed: ipc/ipc_channel.h:270
  error: ipc/ipc_channel.h: patch does not apply

Patch:       ipc/ipc_channel.h
Index: ipc/ipc_channel.h
diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h
index
f8857447033932f14c7a62a08901ddf0d388334c..e51ee57e9c54a0b4b83a0398cae5bd779ce03260
100644
--- a/ipc/ipc_channel.h
+++ b/ipc/ipc_channel.h
@@ -270,16 +270,6 @@ class IPC_EXPORT Channel : public Endpoint {
   static std::string GenerateVerifiedChannelID(const std::string& prefix);
 #endif
 
-  // Deprecated: Create a mojo::MessagePipe directly and release() its handles
-  // instead.
-  //
-  // Generates a pair of channel handles that can be used as the client and
-  // server ends of a ChannelMojo. |name_postfix| is ignored.
-  static void GenerateMojoChannelHandlePair(
-      const std::string& name_postfix,
-      IPC::ChannelHandle* handle0,
-      IPC::ChannelHandle* handle1);
-
 #if defined(OS_LINUX)
   // Sandboxed processes live in a PID namespace, so when sending the IPC hello
   // message from client to server we need to send the PID from the global

[Sam McNally, 2016-11-14 02:44:44]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-11-14 02:44:44]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
raymes@chromium.org, sky@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2484943004/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-14 02:45:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 03:29:35]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2016-11-14 03:32:12]

Description was changed from

==========
Remove unused parts of IPC::ChannelHandle.

In SFI NaCl, ChannelHandle is just a file descriptor. On other platforms
it's just a mojo message pipe handle. This CL removes the other unused
fields. It also removes IPC::Channel::GenerateMojoChannelHandlePair()
and updates its remaining use.

BUG=659448
==========

to

==========
Remove unused parts of IPC::ChannelHandle.

In SFI NaCl, ChannelHandle is just a file descriptor. On other platforms
it's just a mojo message pipe handle. This CL removes the other unused
fields. It also removes IPC::Channel::GenerateMojoChannelHandlePair()
and updates its remaining use.

BUG=659448

Committed: https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024
Cr-Commit-Position: refs/heads/master@{#431821}
==========

[commit-bot: I haz the power, 2016-11-14 03:32:13]

Patchset 3 (id:??) landed as
https://crrev.com/9bf370c24d97be78187311bb28bc3275a1195024
Cr-Commit-Position: refs/heads/master@{#431821}