|
Revert of Service Manager: Remove ServiceContext* arg from Service::OnStart() (patchset #7 id:120001 of https://codereview.chromium.org/2487573002/ )
Reason for revert:
Compile failure, conflicting with another CL
Original issue's description:
> Service Manager: Remove ServiceContext* arg from Service::OnStart()
>
> This restores the context() accessor to Service, but now
> guarantees that ServiceContext always sets the context
> before invoking OnStart().
>
> This means that all Service implementations are free to safely
> access context() any time after OnStart() regardless of what
> service-running mechanism was used to create their
> ServiceContext.
>
> BUG= 654986
>
> Committed: https://crrev.com/6d9b6cd9869d3f8385a42b3272edd7f5b3a6ac5e
> Cr-Commit-Position: refs/heads/master@{#431752}
TBR=ben@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 654986
Committed: https://crrev.com/13d2c57f10e29de32f916e28ba2eda880f29775c
Cr-Commit-Position: refs/heads/master@{#431754}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+336 lines, -243 lines) |
Patch |
 |
M |
ash/autoclick/mus/autoclick_application.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/autoclick/mus/autoclick_application.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ash/mus/window_manager_application.h
|
View
|
|
2 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
ash/mus/window_manager_application.cc
|
View
|
|
2 chunks |
+9 lines, -7 lines |
0 comments
|
Download
|
 |
M |
ash/touch_hud/mus/touch_hud_application.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
ash/touch_hud/mus/touch_hud_application.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/filesystem/file_system_app.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/filesystem/file_system_app.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/font_service/font_service_app.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/font_service/font_service_app.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/leveldb/leveldb_app.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/leveldb/leveldb_app.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/common/service_manager/service_manager_connection_impl.cc
|
View
|
|
3 chunks |
+31 lines, -3 lines |
0 comments
|
Download
|
 |
M |
mash/browser/browser.h
|
View
|
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
mash/browser/browser.cc
|
View
|
|
1 chunk |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
mash/catalog_viewer/catalog_viewer.h
|
View
|
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
mash/catalog_viewer/catalog_viewer.cc
|
View
|
|
2 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
mash/example/views_examples/views_examples.cc
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
mash/example/window_type_launcher/window_type_launcher.h
|
View
|
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
mash/example/window_type_launcher/window_type_launcher.cc
|
View
|
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
mash/init/init.h
|
View
|
|
3 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
mash/init/init.cc
|
View
|
|
3 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
mash/login/login.cc
|
View
|
|
2 chunks |
+12 lines, -10 lines |
0 comments
|
Download
|
 |
M |
mash/quick_launch/quick_launch.h
|
View
|
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
mash/quick_launch/quick_launch.cc
|
View
|
|
2 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
mash/screenlock/screenlock.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
mash/screenlock/screenlock.cc
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
mash/session/session.h
|
View
|
|
3 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
mash/session/session.cc
|
View
|
|
4 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
mash/task_viewer/task_viewer.h
|
View
|
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
mash/task_viewer/task_viewer.cc
|
View
|
|
3 chunks |
+8 lines, -6 lines |
0 comments
|
Download
|
 |
M |
mash/webtest/webtest.h
|
View
|
|
3 chunks |
+7 lines, -1 line |
0 comments
|
Download
|
 |
M |
mash/webtest/webtest.cc
|
View
|
|
2 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
media/mojo/services/media_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/mojo/services/media_service.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
services/device/device_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
services/device/device_service.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
services/file/file_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
services/file/file_service.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
services/image_decoder/image_decoder_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
services/image_decoder/image_decoder_service.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/public/cpp/lib/service.cc
|
View
|
|
1 chunk |
+2 lines, -33 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/public/cpp/lib/service_context.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/public/cpp/lib/service_test.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/public/cpp/service.h
|
View
|
|
2 chunks |
+16 lines, -43 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/public/cpp/service_test.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/connect/connect_test_app.cc
|
View
|
|
8 chunks |
+11 lines, -10 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/connect/connect_test_class_app.cc
|
View
|
|
3 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/connect/connect_test_exe.cc
|
View
|
|
2 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/connect/connect_test_package.cc
|
View
|
|
8 chunks |
+42 lines, -13 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/lifecycle/app_client.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/lifecycle/app_client.cc
|
View
|
|
3 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/lifecycle/package.cc
|
View
|
|
4 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/lifecycle/parent.cc
|
View
|
|
3 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/service_manager/target.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
services/service_manager/tests/shutdown/shutdown_client_app.cc
|
View
|
|
3 chunks |
+6 lines, -1 line |
0 comments
|
Download
|
 |
M |
services/ui/demo/mus_demo.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
services/ui/demo/mus_demo.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
services/ui/ime/test_ime_driver/test_ime_application.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
services/ui/ime/test_ime_driver/test_ime_application.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
services/ui/service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
services/ui/service.cc
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
services/ui/test_wm/test_wm.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|