services/service_manager/public/cpp/lib/service_context.cc - Issue 2494303002: Revert of Service Manager: Remove ServiceContext* arg from Service::OnStart()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/service_manager/public/cpp/lib/service_context.cc

Issue 2494303002: Revert of Service Manager: Remove ServiceContext* arg from Service::OnStart() (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/service_manager/public/cpp/lib/service_context.cc

diff --git a/services/service_manager/public/cpp/lib/service_context.cc b/services/service_manager/public/cpp/lib/service_context.cc

index d2997a67cecb196075c617a570d90840b085cb55..d95d60629ee2e696867663b376e565222be35edf 100644

--- a/services/service_manager/public/cpp/lib/service_context.cc

+++ b/services/service_manager/public/cpp/lib/service_context.cc

@@ -81,9 +81,7 @@

local_info_ = info;

callback.Run(std::move(pending_connector_request_),

mojo::GetProxy(&service_control_, binding_.associated_group()));

- service_->set_context(this);

- service_->OnStart();

+ service_->OnStart(this);

}

void ServiceContext::OnConnect(