Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: milo/appengine/buildbucket/html.go

Issue 2494243002: Milo: Fix more builds link in builders page (Closed)
Patch Set: Added notes to builder html handlers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/buildbucket/html.go
diff --git a/milo/appengine/buildbucket/html.go b/milo/appengine/buildbucket/html.go
index 4a75a19272fb475cb305100e95f0be61370e6e29..9bfc5187a7799d611afd64d2c422d5203d182bf2 100644
--- a/milo/appengine/buildbucket/html.go
+++ b/milo/appengine/buildbucket/html.go
@@ -27,6 +27,8 @@ func (b Builder) GetTemplateName(t settings.Theme) string {
}
// Render renders builder view page.
+// Note: The builder html template contains self links to "?limit=123", which could
+// potentially override any other request parameters set.
func (b Builder) Render(c context.Context, r *http.Request, p httprouter.Params) (*templates.Args, error) {
// Parse URL parameters.
server := r.FormValue("server")

Powered by Google App Engine
This is Rietveld 408576698