Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: milo/appengine/buildbot/html.go

Issue 2494243002: Milo: Fix more builds link in builders page (Closed)
Patch Set: Added notes to builder html handlers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | milo/appengine/buildbucket/html.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/html.go
diff --git a/milo/appengine/buildbot/html.go b/milo/appengine/buildbot/html.go
index ba8e007479ea61641f4dd609a8b8338ce15d02ad..cf16e70572af8658ba00b2288d03b1b40a9dd8d2 100644
--- a/milo/appengine/buildbot/html.go
+++ b/milo/appengine/buildbot/html.go
@@ -79,6 +79,8 @@ func (b Builder) GetTemplateName(t settings.Theme) string {
}
// Render renders the buildbot builder page.
+// Note: The builder html template contains self links to "?limit=123", which could
+// potentially override any other request parameters set.
func (b Builder) Render(c context.Context, r *http.Request, p httprouter.Params) (*templates.Args, error) {
master := p.ByName("master")
if master == "" {
« no previous file with comments | « no previous file | milo/appengine/buildbucket/html.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698