Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2494243002: Milo: Fix more builds link in builders page (Closed)

Created:
4 years, 1 month ago by Ryan Tseng
Modified:
4 years, 1 month ago
Reviewers:
nodir, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Fix more builds link in builders page BUG=664665 Committed: https://github.com/luci/luci-go/commit/f09dd009cc8aea2c2c92a9e962899f6336745ec4

Patch Set 1 #

Patch Set 2 : Expectations #

Total comments: 1

Patch Set 3 : Added notes to builder html handlers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M milo/appengine/buildbot/html.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M milo/appengine/buildbucket/html.go View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_no_builds.html View 1 1 chunk +5 lines, -5 lines 0 comments Download
M milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuilder-Basic_Test_with_builds.html View 1 1 chunk +5 lines, -5 lines 0 comments Download
M milo/appengine/frontend/templates/buildbot/pages/builder.html View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Ryan Tseng
Expectations
4 years, 1 month ago (2016-11-11 23:55:12 UTC) #5
hinoka
ptal Demo: https://1237-25201ba-tainted-hinoka-dot-luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng
4 years, 1 month ago (2016-11-14 20:00:02 UTC) #11
nodir
lgtm https://codereview.chromium.org/2494243002/diff/20001/milo/appengine/frontend/templates/buildbot/pages/builder.html File milo/appengine/frontend/templates/buildbot/pages/builder.html (right): https://codereview.chromium.org/2494243002/diff/20001/milo/appengine/frontend/templates/buildbot/pages/builder.html#newcode121 milo/appengine/frontend/templates/buildbot/pages/builder.html:121: <a href="?limit=200">200</a> note that this will kill any ...
4 years, 1 month ago (2016-11-14 20:20:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494243002/40001
4 years, 1 month ago (2016-11-16 00:40:01 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 00:46:37 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/f09dd009cc8aea2c2c92a9e962899f6336745ec4

Powered by Google App Engine
This is Rietveld 408576698