Fix a data race in multiple unit tests processes.

Fix a data race in multiple unit tests processes.

There is a race between TestSuite::Initialize() initializing logging
and the "test_io_thread" using assert(). This CL fixes this race by
initializing logging in the constructor of TestSuite, before any
thread is created.

See failing unit tests in this CL:
https://codereview.chromium.org/2502973002/

BUG=665945
Committed: https://crrev.com/4394a610dc161262d1ec2913d55e29727a79d25f
Cr-Commit-Position: refs/heads/master@{#432869}

[fdoray, 2016-11-11 16:24:18]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 16:24:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 16:32:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 16:32:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[fdoray, 2016-11-16 18:01:36]

Description was changed from

==========
Initialize logging in TestSuite constructor.

There is a race between TestSuite::Initialize() initializing logging
and the "test_io_thread" initialized in some tests calling a logging
function. This CL fixes this race by initializing logging in the
constructor of TestSuite.

Sample race report:

WARNING: ThreadSanitizer: data race (pid=16498)
  Read of size 4 at 0x0000008c38a0 by thread T1:
    #0 logging::ShouldCreateLogMessage(int) base/logging.cc:412:10
(url_unittests+0x000000542307)
    #1 operator-> base/memory/ref_counted.h:319:5 (url_unittests+0x0000005460e3)
    #2 base::MessageLoop::BindToCurrentThread()
base/message_loop/message_loop.cc:343 (url_unittests+0x0000005460e3)
    #3 base::Thread::ThreadMain() base/threading/thread.cc:299:18
(url_unittests+0x0000005a9240)
    #4 base::(anonymous namespace)::ThreadFunc(void*)
base/threading/platform_thread_posix.cc:71:13 (url_unittests+0x000000561cb8)

  Previous write of size 4 at 0x0000008c38a0 by main thread:
    #0 logging::BaseInitLoggingImpl_built_with_NDEBUG(logging::LoggingSettings
const&) base/logging.cc:373:25 (url_unittests+0x000000541fe4)
    #1 InitLogging base/logging.h:232:10 (url_unittests+0x0000005c88ea)
    #2 base::TestSuite::Initialize() base/test/test_suite.cc:332
(url_unittests+0x0000005c88ea)
    #3 base::TestSuite::Run() base/test/test_suite.cc:235:3
(url_unittests+0x0000005c82a7)
    #4 Invoke<base::TestSuite *> base/bind_internal.h:214:12
(url_unittests+0x0000004ca905)
    #5 MakeItSo<int (base::TestSuite::*const &)(), base::TestSuite *>
base/bind_internal.h:285 (url_unittests+0x0000004ca905)
    #6 RunImpl<int (base::TestSuite::*const &)(), const
std::__1::tuple<base::internal::UnretainedWrapper<base::TestSuite> > &, 0>
base/bind_internal.h:361 (url_unittests+0x0000004ca905)
    #7 base::internal::Invoker<base::internal::BindState<int
(base::TestSuite::*)(), base::internal::UnretainedWrapper<base::TestSuite> >,
int ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339
(url_unittests+0x0000004ca905)
    #8 Run base/callback.h:64:12 (url_unittests+0x0000005c9c83)
    #9 base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int
(), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int,
int, bool, base::Callback<void (), (base::internal::CopyMode)1,
(base::internal::RepeatMode)1> const&)
base/test/launcher/unit_test_launcher.cc:210 (url_unittests+0x0000005c9c83)
    #10 base::LaunchUnitTests(int, char**, base::Callback<int (),
(base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)
base/test/launcher/unit_test_launcher.cc:452:10 (url_unittests+0x0000005c9aaa)
    #11 main url/run_all_unittests.cc:30:10 (url_unittests+0x0000004ca83d)

  Location is global 'logging::(anonymous namespace)::g_logging_destination' of
size 4 at 0x0000008c38a0 (url_unittests+0x0000008c38a0)

  Thread T1 'test_io_thread' (tid=16512, running) created by main thread at:
    #0 pthread_create <null> (url_unittests+0x00000044bc65)
    #1 base::(anonymous namespace)::CreateThread(unsigned long, bool,
base::PlatformThread::Delegate*, base::PlatformThreadHandle*,
base::ThreadPriority) base/threading/platform_thread_posix.cc:110:13
(url_unittests+0x000000561855)
    #2 base::PlatformThread::CreateWithPriority(unsigned long,
base::PlatformThread::Delegate*, base::PlatformThreadHandle*,
base::ThreadPriority) base/threading/platform_thread_posix.cc:191:10
(url_unittests+0x000000561705)
    #3 base::Thread::StartWithOptions(base::Thread::Options const&)
base/threading/thread.cc:112:15 (url_unittests+0x0000005a8835)
    #4 base::TestIOThread::Start() base/test/test_io_thread.cc:30:3
(url_unittests+0x0000005c81ba)
    #5 base::TestIOThread::TestIOThread(base::TestIOThread::Mode)
base/test/test_io_thread.cc:15:7 (url_unittests+0x0000005c80ae)
    #6 main url/run_all_unittests.cc:24:22 (url_unittests+0x0000004ca764)

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

BUG=
==========

to

==========
Fix a data race in multiple unit tests processes.

There is a race between TestSuite::Initialize() initializing logging
and the "test_io_thread" using assert(). This CL fixes this race by
initializing logging in the constructor of TestSuite, before any
thread is created.

BUG=665945
==========

[fdoray, 2016-11-16 18:03:11]

Description was changed from

==========
Fix a data race in multiple unit tests processes.

There is a race between TestSuite::Initialize() initializing logging
and the "test_io_thread" using assert(). This CL fixes this race by
initializing logging in the constructor of TestSuite, before any
thread is created.

BUG=665945
==========

to

==========
Fix a data race in multiple unit tests processes.

There is a race between TestSuite::Initialize() initializing logging
and the "test_io_thread" using assert(). This CL fixes this race by
initializing logging in the constructor of TestSuite, before any
thread is created.

See failing unit tests in this CL:
https://codereview.chromium.org/2502973002/

BUG=665945
==========

[fdoray, 2016-11-16 18:04:34]

fdoray@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, thestig@chromium.org

[fdoray, 2016-11-16 18:04:35]

phajdan.jr@: PTAL

thestig@: FYI

[Paweł Hajdan Jr., 2016-11-17 07:47:59]

LGTM

[fdoray, 2016-11-17 13:13:24]

fdoray@chromium.org changed reviewers:
+ nhiroki@chromium.org

[fdoray, 2016-11-17 13:13:24]

nhiroki@: Please review changes in chrome/browser/sync_file_system/

[nhiroki, 2016-11-17 13:33:36]

On 2016/11/17 13:13:24, fdoray wrote:
> nhiroki@: Please review changes in chrome/browser/sync_file_system/

lgtm

[fdoray, 2016-11-17 13:36:02]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-11-17 13:36:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 14:41:53]

Description was changed from

==========
Fix a data race in multiple unit tests processes.

There is a race between TestSuite::Initialize() initializing logging
and the "test_io_thread" using assert(). This CL fixes this race by
initializing logging in the constructor of TestSuite, before any
thread is created.

See failing unit tests in this CL:
https://codereview.chromium.org/2502973002/

BUG=665945
==========

to

==========
Fix a data race in multiple unit tests processes.

There is a race between TestSuite::Initialize() initializing logging
and the "test_io_thread" using assert(). This CL fixes this race by
initializing logging in the constructor of TestSuite, before any
thread is created.

See failing unit tests in this CL:
https://codereview.chromium.org/2502973002/

BUG=665945
==========

[commit-bot: I haz the power, 2016-11-17 14:41:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-17 14:46:16]

Description was changed from

==========
Fix a data race in multiple unit tests processes.

There is a race between TestSuite::Initialize() initializing logging
and the "test_io_thread" using assert(). This CL fixes this race by
initializing logging in the constructor of TestSuite, before any
thread is created.

See failing unit tests in this CL:
https://codereview.chromium.org/2502973002/

BUG=665945
==========

to

==========
Fix a data race in multiple unit tests processes.

There is a race between TestSuite::Initialize() initializing logging
and the "test_io_thread" using assert(). This CL fixes this race by
initializing logging in the constructor of TestSuite, before any
thread is created.

See failing unit tests in this CL:
https://codereview.chromium.org/2502973002/

BUG=665945

Committed: https://crrev.com/4394a610dc161262d1ec2913d55e29727a79d25f
Cr-Commit-Position: refs/heads/master@{#432869}
==========

[commit-bot: I haz the power, 2016-11-17 14:46:17]

Patchset 5 (id:??) landed as
https://crrev.com/4394a610dc161262d1ec2913d55e29727a79d25f
Cr-Commit-Position: refs/heads/master@{#432869}