Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1971)

Unified Diff: base/test/test_support_android.cc

Issue 2494133002: Fix a data race in multiple unit tests processes. (Closed)
Patch Set: fix logger test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/test_support_android.h ('k') | chrome/browser/sync_file_system/logger_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/test_support_android.cc
diff --git a/base/test/test_support_android.cc b/base/test/test_support_android.cc
index c35e6197fc2bb02981793f7caadcaaa33ac63e29..d77405fbf07334de821a638e261b016d82ea831b 100644
--- a/base/test/test_support_android.cc
+++ b/base/test/test_support_android.cc
@@ -160,6 +160,9 @@ void InitPathProvider(int key) {
namespace base {
void InitAndroidTestLogging() {
+ if (base::AndroidIsChildProcess())
+ return;
+
logging::LoggingSettings settings;
settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
logging::InitLogging(settings);
@@ -185,10 +188,4 @@ void InitAndroidTestMessageLoop() {
LOG(INFO) << "MessagePumpForUIFactory already set, unable to override.";
}
-void InitAndroidTest() {
- if (!base::AndroidIsChildProcess()) {
- InitAndroidTestLogging();
- }
- InitAndroidTestMessageLoop();
-}
} // namespace base
« no previous file with comments | « base/test/test_support_android.h ('k') | chrome/browser/sync_file_system/logger_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698