Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 2494113003: Do not typedef ExtensionId/ID, since it's already available in extension_id.h (Closed)

Created:
4 years, 1 month ago by lazyboy
Modified:
4 years, 1 month ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not typedef ExtensionId/ID, since it's already available in extension_id.h BUG=None Test=None, minor cleanup. Committed: https://crrev.com/0222b3631d68f4b75cd4fe05c35baf5eb5733957 Cr-Commit-Position: refs/heads/master@{#431738}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix includes from comments #

Messages

Total messages: 18 (12 generated)
lazyboy
4 years, 1 month ago (2016-11-11 23:05:55 UTC) #4
Devlin
lgtm, thanks! https://codereview.chromium.org/2494113003/diff/1/extensions/browser/api/declarative/declarative_rule.h File extensions/browser/api/declarative/declarative_rule.h (right): https://codereview.chromium.org/2494113003/diff/1/extensions/browser/api/declarative/declarative_rule.h#newcode27 extensions/browser/api/declarative/declarative_rule.h:27: #include "extensions/common/extension.h" #include extension_id https://codereview.chromium.org/2494113003/diff/1/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc File extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc ...
4 years, 1 month ago (2016-11-11 23:10:06 UTC) #5
lazyboy
https://codereview.chromium.org/2494113003/diff/1/extensions/browser/api/declarative/declarative_rule.h File extensions/browser/api/declarative/declarative_rule.h (right): https://codereview.chromium.org/2494113003/diff/1/extensions/browser/api/declarative/declarative_rule.h#newcode27 extensions/browser/api/declarative/declarative_rule.h:27: #include "extensions/common/extension.h" On 2016/11/11 23:10:06, Devlin (slow) wrote: > ...
4 years, 1 month ago (2016-11-12 00:13:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2494113003/20001
4 years, 1 month ago (2016-11-12 01:54:25 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-12 02:00:37 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 02:02:16 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0222b3631d68f4b75cd4fe05c35baf5eb5733957
Cr-Commit-Position: refs/heads/master@{#431738}

Powered by Google App Engine
This is Rietveld 408576698