extensions/browser/api/declarative/rules_registry.h - Issue 2494113003: Do not typedef ExtensionId/ID, since it's already available in extension_id.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/rules_registry.h

Issue 2494113003: Do not typedef ExtensionId/ID, since it's already available in extension_id.h (Closed)

Patch Set: fix includes from comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/declarative/rules_registry.h

diff --git a/extensions/browser/api/declarative/rules_registry.h b/extensions/browser/api/declarative/rules_registry.h

index a1d4a982891b6e2a668465b99cb7853a9d067bc6..99dfde2d3c10a6ccd750639085d94e8004d736cd 100644

--- a/extensions/browser/api/declarative/rules_registry.h

+++ b/extensions/browser/api/declarative/rules_registry.h

@@ -22,6 +22,7 @@

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "extensions/common/api/events.h"

+#include "extensions/common/extension_id.h"

#include "extensions/common/one_shot_event.h"

namespace content {

@@ -156,7 +157,6 @@ class RulesRegistry : public base::RefCountedThreadSafe<RulesRegistry> {

friend class base::RefCountedThreadSafe<RulesRegistry>;

friend class RulesCacheDelegate;

- typedef std::string ExtensionId;

typedef std::string RuleId;

typedef std::pair<ExtensionId, RuleId> RulesDictionaryKey;

typedef std::map<RulesDictionaryKey, linked_ptr<api::events::Rule>>