Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2494013003: Remove screen_capturer_mock_objects.h (Closed)

Created:
4 years, 1 month ago by Hzj_jie
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov, Jamie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove screen_capturer_mock_objects.h This is a trivial change to remove MockScreenCapturerCallback, and use MockDesktopCapturerCallback to replace it. BUG=webrtc:6513 Committed: https://crrev.com/372719b577775939cd0f12e0ba7239d930f2fc68 Cr-Commit-Position: refs/heads/master@{#15047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -57 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/mock_desktop_capturer_callback.h View 1 chunk +21 lines, -3 lines 0 comments Download
A + webrtc/modules/desktop_capture/mock_desktop_capturer_callback.cc View 1 chunk +11 lines, -8 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D webrtc/modules/desktop_capture/screen_capturer_mock_objects.h View 1 chunk +0 lines, -41 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Hzj_jie
4 years, 1 month ago (2016-11-12 00:56:03 UTC) #9
Sergey Ulanov
lgtm
4 years, 1 month ago (2016-11-12 01:04:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2494013003/20001
4 years, 1 month ago (2016-11-12 01:17:00 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-12 01:18:37 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 01:18:42 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/372719b577775939cd0f12e0ba7239d930f2fc68
Cr-Commit-Position: refs/heads/master@{#15047}

Powered by Google App Engine
This is Rietveld 408576698