[Cronet] Ignore Certificate Transparency to avoid CT log expiration.

[Cronet] Ignore Certificate Transparency to avoid CT log expiration.

BUG=663883

[mef, 2016-11-10 20:19:45]

Description was changed from

==========
Make Cronet ignore Certificate Transparency to avoid CT log expiration.

BUG=663883
==========

to

==========
[Cronet] Ignore Certificate Transparency to avoid CT log expiration.

BUG=663883
==========

[mef, 2016-11-10 20:19:45]

mef@chromium.org changed reviewers:
+ rsleevi@chromium.org

[mef, 2016-11-10 20:55:43]

Hi Ryan, PTAL. 

Does it make sense?
What's a good way to test this?
If Cronet ignores CT, how can we exclude logs from being compiled into resulting
binaries?

https://codereview.chromium.org/2493863002/diff/20001/components/cronet/ios/c...
File components/cronet/ios/cronet_environment.cc (right):

https://codereview.chromium.org/2493863002/diff/20001/components/cronet/ios/c...
components/cronet/ios/cronet_environment.cc:302:
main_context_->set_cert_transparency_verifier(new IgnoresCTVerifier());
The iOS implementation is being reworked to use UrlRequestContextBuilder, but is
not there yet.

[Ryan Sleevi, 2016-11-10 20:59:26]

Before I get too far into reviewing this - does
https://codereview.chromium.org/2495583002/ work?

[Ryan Sleevi, 2016-11-10 20:59:57]

On 2016/11/10 20:55:43, mef wrote:
> Does it make sense?
> What's a good way to test this?
> If Cronet ignores CT, how can we exclude logs from being compiled into
resulting
> binaries?

Rely on the linker to exclude unused code :)

[mef, 2016-11-10 21:04:47]

On 2016/11/10 20:59:26, Ryan Sleevi wrote:
> Before I get too far into reviewing this - does
> https://codereview.chromium.org/2495583002/ work?

I guess that should work, and it is better as it gives CT benefits to timely
builds.
I knew that I should've procrastinated a bit longer!

[mef, 2016-11-10 21:06:09]

On 2016/11/10 20:59:57, Ryan Sleevi wrote:
> On 2016/11/10 20:55:43, mef wrote:
> > Does it make sense?
> > What's a good way to test this?
> > If Cronet ignores CT, how can we exclude logs from being compiled into
> resulting
> > binaries?
> 
> Rely on the linker to exclude unused code :)

That may not work due to runtime selection in
https://cs.chromium.org/chromium/src/net/url_request/url_request_context_buil...

[Ryan Sleevi, 2016-11-14 05:16:57]

Closing this out now that the timebomb has been defanged.