Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: components/cronet/android/cronet_url_request_context_adapter.cc

Issue 2493863002: [Cronet] Ignore Certificate Transparency to avoid CT log expiration. (Closed)
Patch Set: Use IgnoresCTVerifier / PolicyEnforcer on iOS. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_url_request_context_adapter.cc
diff --git a/components/cronet/android/cronet_url_request_context_adapter.cc b/components/cronet/android/cronet_url_request_context_adapter.cc
index 112762c17d925b68581eb5669df826b42e3b0f64..c5577784bbf6f44118e3d3b158177b946f1b7bc4 100644
--- a/components/cronet/android/cronet_url_request_context_adapter.cc
+++ b/components/cronet/android/cronet_url_request_context_adapter.cc
@@ -33,6 +33,7 @@
#include "base/values.h"
#include "components/cronet/android/cert/cert_verifier_cache_serializer.h"
#include "components/cronet/android/cert/proto/cert_verification.pb.h"
+#include "components/cronet/ct_ignores.h"
#include "components/cronet/histogram_manager.h"
#include "components/cronet/url_request_context_config.h"
#include "components/prefs/pref_change_registrar.h"
@@ -605,6 +606,11 @@ void CronetURLRequestContextAdapter::InitializeOnNetworkThread(
// of HPKP by specifying transport_security_persister_path in the future.
context_builder.set_transport_security_persister_path(base::FilePath());
+ // Ignore Certificate Transparency to avoid log expiration (crbug.com/663883).
+ context_builder.set_ct_verifier(base::MakeUnique<IgnoresCTVerifier>());
+ context_builder.set_ct_policy_enforcer(
+ base::MakeUnique<IgnoresCTPolicyEnforcer>());
+
// Disable net::CookieStore and net::ChannelIDService.
context_builder.SetCookieAndChannelIdStores(nullptr, nullptr);

Powered by Google App Engine
This is Rietveld 408576698