third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h - Issue 2493833004: InitialColumnHeightFinder needs to take all expected rows into account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

Issue 2493833004: InitialColumnHeightFinder needs to take all expected rows into account. (Closed)

Patch Set: Code review Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

index 91e67bbfa3ec91e34540a4f522ef34fc8b0556f7..d92d9735c62f0033389ae67afca5a111720a167c 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

@@ -107,6 +107,11 @@ class CORE_EXPORT LayoutMultiColumnSet : public LayoutBlockFlow {

LayoutUnit pageRemainingLogicalHeightForOffset(LayoutUnit,

PageBoundaryRule) const;

bool isPageLogicalHeightKnown() const;

+ // Return true if there's nothing with the current state of column balancing

+ // that prevents us from inserting additional fragmentainer groups, if needed.

+ bool newFragmentainerGroupsAllowed() const;

LayoutUnit tallestUnbreakableLogicalHeight() const {

return m_tallestUnbreakableLogicalHeight;

}