Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

Issue 2493833004: InitialColumnHeightFinder needs to take all expected rows into account. (Closed)
Patch Set: Code review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 LayoutBlockFlow::isOfType(type); 100 LayoutBlockFlow::isOfType(type);
101 } 101 }
102 bool canHaveChildren() const final { return false; } 102 bool canHaveChildren() const final { return false; }
103 103
104 // Return the width and height of a single column or page in the set. 104 // Return the width and height of a single column or page in the set.
105 LayoutUnit pageLogicalWidth() const { return flowThread()->logicalWidth(); } 105 LayoutUnit pageLogicalWidth() const { return flowThread()->logicalWidth(); }
106 LayoutUnit pageLogicalHeightForOffset(LayoutUnit) const; 106 LayoutUnit pageLogicalHeightForOffset(LayoutUnit) const;
107 LayoutUnit pageRemainingLogicalHeightForOffset(LayoutUnit, 107 LayoutUnit pageRemainingLogicalHeightForOffset(LayoutUnit,
108 PageBoundaryRule) const; 108 PageBoundaryRule) const;
109 bool isPageLogicalHeightKnown() const; 109 bool isPageLogicalHeightKnown() const;
110
111 // Return true if there's nothing with the current state of column balancing
112 // that prevents us from inserting additional fragmentainer groups, if needed.
113 bool newFragmentainerGroupsAllowed() const;
114
110 LayoutUnit tallestUnbreakableLogicalHeight() const { 115 LayoutUnit tallestUnbreakableLogicalHeight() const {
111 return m_tallestUnbreakableLogicalHeight; 116 return m_tallestUnbreakableLogicalHeight;
112 } 117 }
113 void propagateTallestUnbreakableLogicalHeight(LayoutUnit value) { 118 void propagateTallestUnbreakableLogicalHeight(LayoutUnit value) {
114 m_tallestUnbreakableLogicalHeight = 119 m_tallestUnbreakableLogicalHeight =
115 std::max(value, m_tallestUnbreakableLogicalHeight); 120 std::max(value, m_tallestUnbreakableLogicalHeight);
116 } 121 }
117 122
118 LayoutUnit nextLogicalTopForUnbreakableContent( 123 LayoutUnit nextLogicalTopForUnbreakableContent(
119 LayoutUnit flowThreadOffset, 124 LayoutUnit flowThreadOffset,
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 LayoutUnit m_oldLogicalTop; 273 LayoutUnit m_oldLogicalTop;
269 274
270 bool m_initialHeightCalculated; 275 bool m_initialHeightCalculated;
271 }; 276 };
272 277
273 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutMultiColumnSet, isLayoutMultiColumnSet()); 278 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutMultiColumnSet, isLayoutMultiColumnSet());
274 279
275 } // namespace blink 280 } // namespace blink
276 281
277 #endif // LayoutMultiColumnSet_h 282 #endif // LayoutMultiColumnSet_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698