 Chromium Code Reviews
 Chromium Code Reviews Issue 2493773003:
  [inspector] Introduce translation of wasm frames  (Closed)
    
  
    Issue 2493773003:
  [inspector] Introduce translation of wasm frames  (Closed) 
  | Index: src/inspector/v8-debugger-agent-impl.h | 
| diff --git a/src/inspector/v8-debugger-agent-impl.h b/src/inspector/v8-debugger-agent-impl.h | 
| index 4e8e336545631d344534410089666c6e45b53d1b..632c859e1b6358dce52214fdb8b9a20d18f0e7fb 100644 | 
| --- a/src/inspector/v8-debugger-agent-impl.h | 
| +++ b/src/inspector/v8-debugger-agent-impl.h | 
| @@ -11,6 +11,7 @@ | 
| #include "src/inspector/java-script-call-frame.h" | 
| #include "src/inspector/protocol/Debugger.h" | 
| #include "src/inspector/protocol/Forward.h" | 
| +#include "src/inspector/wasm-translation.h" | 
| namespace v8_inspector { | 
| @@ -142,6 +143,10 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend { | 
| void didParseSource(std::unique_ptr<V8DebuggerScript>, bool success); | 
| void willExecuteScript(int scriptId); | 
| void didExecuteScript(); | 
| + void newWasmScript(v8::Local<v8::Object> scriptWrapper); | 
| 
kozy
2016/11/16 16:44:53
I prefer to expose WasmTranslation* wasmTranslatio
 
Clemens Hammacher
2016/11/16 16:57:31
Done.
 | 
| + | 
| + void translateWasmScriptLocation(String16* scriptId, int* lineNumber, | 
| + int* columnNumber); | 
| v8::Isolate* isolate() { return m_isolate; } | 
| @@ -215,6 +220,10 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend { | 
| protocol::HashMap<String16, std::vector<std::pair<int, int>>> | 
| m_blackboxedPositions; | 
| + WasmTranslation m_wasmTranslation; | 
| + | 
| + friend class WasmTranslation; | 
| 
kozy
2016/11/16 16:44:53
Why WasmTranslation is friend? It looks like WasmT
 
Clemens Hammacher
2016/11/16 16:57:31
Good catch! It's not needed any more, I removed it
 | 
| + | 
| DISALLOW_COPY_AND_ASSIGN(V8DebuggerAgentImpl); | 
| }; |