[inspector] Introduce translation of wasm frames

src/inspector/v8-debugger-agent-impl.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_
 #define V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_
 
 #include <vector>
 
 #include "src/base/macros.h"
 #include "src/inspector/java-script-call-frame.h"
 #include "src/inspector/protocol/Debugger.h"
 #include "src/inspector/protocol/Forward.h"
+#include "src/inspector/wasm-translation.h"
 
 namespace v8_inspector {
 
 struct ScriptBreakpoint;
 class JavaScriptCallFrame;
 class PromiseTracker;
 class V8Debugger;
 class V8DebuggerScript;
 class V8InspectorImpl;
 class V8InspectorSessionImpl;
@@ skipping 111 matching lines @@
 
   // Interface for V8InspectorImpl
   SkipPauseRequest didPause(v8::Local<v8::Context>,
                             v8::Local<v8::Value> exception,
                             const std::vector<String16>& hitBreakpoints,
                             bool isPromiseRejection, bool isUncaught);
   void didContinue();
   void didParseSource(std::unique_ptr<V8DebuggerScript>, bool success);
   void willExecuteScript(int scriptId);
   void didExecuteScript();
+  void newWasmScript(v8::Local<v8::Object> scriptWrapper);

[kozy, 2016/11/16 16:44:53]

I prefer to expose WasmTranslation* wasmTranslation() { return
&m_wasnTranslation; } and use it directly.

[Clemens Hammacher, 2016/11/16 16:57:31]

Done.

+
+  void translateWasmScriptLocation(String16* scriptId, int* lineNumber,
+                                   int* columnNumber);
 
   v8::Isolate* isolate() { return m_isolate; }
 
  private:
   void enableImpl();
 
   SkipPauseRequest shouldSkipExceptionPause(JavaScriptCallFrame* topCallFrame);
   SkipPauseRequest shouldSkipStepPause(JavaScriptCallFrame* topCallFrame);
 
   void schedulePauseOnNextStatementIfSteppingInto();
@@ skipping 53 matching lines @@
 
   int m_skippedStepFrameCount;
   int m_recursionLevelForStepOut;
   int m_recursionLevelForStepFrame;
   bool m_skipAllPauses;
 
   std::unique_ptr<V8Regex> m_blackboxPattern;
   protocol::HashMap<String16, std::vector<std::pair<int, int>>>
       m_blackboxedPositions;
 
+  WasmTranslation m_wasmTranslation;
+
+  friend class WasmTranslation;

[kozy, 2016/11/16 16:44:53]

Why WasmTranslation is friend? It looks like WasmTranslation uses only public
didParseSource method.

[Clemens Hammacher, 2016/11/16 16:57:31]

Good catch! It's not needed any more, I removed it.

+
   DISALLOW_COPY_AND_ASSIGN(V8DebuggerAgentImpl);
 };
 
 }  // namespace v8_inspector
 
 #endif  // V8_INSPECTOR_V8DEBUGGERAGENTIMPL_H_