Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2493713002: IDBObserver does not need to be GC finalizable. (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years, 1 month ago
Reviewers:
haraken, jsbell
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, cmumford
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IDBObserver does not need to be GC finalizable. R=haraken BUG= Committed: https://crrev.com/50f8cdded77e9d6250181600724bb52d29c86664 Cr-Commit-Position: refs/heads/master@{#431268}

Patch Set 1 #

Patch Set 2 : formatting only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IDBObserver.h View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
sof
please take a look. :)
4 years, 1 month ago (2016-11-10 09:20:29 UTC) #7
haraken
On 2016/11/10 09:20:29, sof wrote: > please take a look. :) Extremely happy to see ...
4 years, 1 month ago (2016-11-10 09:21:29 UTC) #8
sof
On 2016/11/10 09:21:29, haraken wrote: > On 2016/11/10 09:20:29, sof wrote: > > please take ...
4 years, 1 month ago (2016-11-10 09:23:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493713002/1
4 years, 1 month ago (2016-11-10 11:43:56 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/301293)
4 years, 1 month ago (2016-11-10 11:50:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493713002/20001
4 years, 1 month ago (2016-11-10 14:44:30 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 16:16:11 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 16:18:59 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50f8cdded77e9d6250181600724bb52d29c86664
Cr-Commit-Position: refs/heads/master@{#431268}

Powered by Google App Engine
This is Rietveld 408576698