|
|
DescriptionIDBObserver does not need to be GC finalizable.
R=haraken
BUG=
Committed: https://crrev.com/50f8cdded77e9d6250181600724bb52d29c86664
Cr-Commit-Position: refs/heads/master@{#431268}
Patch Set 1 #Patch Set 2 : formatting only #Messages
Total messages: 21 (13 generated)
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== IDBObserver does not need to be GC finalizable. BUG= ========== to ========== IDBObserver does not need to be GC finalizable. R= BUG= ==========
sigbjornf@opera.com changed reviewers: + haraken@chromium.org, jsbell@chromium.org
please take a look. :)
On 2016/11/10 09:20:29, sof wrote: > please take a look. :) Extremely happy to see you here!! LGTM
On 2016/11/10 09:21:29, haraken wrote: > On 2016/11/10 09:20:29, sof wrote: > > please take a look. :) > > Extremely happy to see you here!! > > LGTM thanks, very good to "see" you again also :)
Description was changed from ========== IDBObserver does not need to be GC finalizable. R= BUG= ========== to ========== IDBObserver does not need to be GC finalizable. R=haraken BUG= ==========
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by sigbjornf@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2493713002/#ps20001 (title: "formatting only")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== IDBObserver does not need to be GC finalizable. R=haraken BUG= ========== to ========== IDBObserver does not need to be GC finalizable. R=haraken BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== IDBObserver does not need to be GC finalizable. R=haraken BUG= ========== to ========== IDBObserver does not need to be GC finalizable. R=haraken BUG= Committed: https://crrev.com/50f8cdded77e9d6250181600724bb52d29c86664 Cr-Commit-Position: refs/heads/master@{#431268} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/50f8cdded77e9d6250181600724bb52d29c86664 Cr-Commit-Position: refs/heads/master@{#431268} |