Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.h

Issue 2493713002: IDBObserver does not need to be GC finalizable. (Closed)
Patch Set: formatting only Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
index bcfdee7e82637f61ea53b7873716e6002147bb43..2b61db8ed728e29ce74657abb9379ddafbee6b3a 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
@@ -21,9 +21,8 @@ class IDBObserverInit;
class IDBTransaction;
struct WebIDBObservation;
-class MODULES_EXPORT IDBObserver final
- : public GarbageCollectedFinalized<IDBObserver>,
- public ScriptWrappable {
+class MODULES_EXPORT IDBObserver final : public GarbageCollected<IDBObserver>,
+ public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
@@ -44,7 +43,7 @@ class MODULES_EXPORT IDBObserver final
DECLARE_TRACE();
private:
- IDBObserver(IDBObserverCallback*);
+ explicit IDBObserver(IDBObserverCallback*);
Member<IDBObserverCallback> m_callback;
HeapHashMap<int32_t, WeakMember<IDBDatabase>> m_observerIds;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698