third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp - Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

Issue 2493673002: Synchronize OffscreenCanvas content with the placeholder canvas (Closed)

Patch Set: build fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/printing/offscreencanvas-2d-printing.html ('K') | « third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp ('k') | third_party/WebKit/Source/core/html/HTMLCanvasElement.h » ('j') | third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

index 1fb262cbe0a7b59c59db6de2505fd30160fe4984..56ab63e3309ae6fa67c885eb4fd25d99ad662c30 100644

--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

@@ -515,7 +515,7 @@ TEST(V8ScriptValueSerializerTest, TransferOffscreenCanvas) {

ScopedEnableV8BasedStructuredClone enable;

V8TestingScope scope;

OffscreenCanvas* canvas = OffscreenCanvas::create(10, 7);

- canvas->setAssociatedCanvasId(519);

+ canvas->setPlaceholderCanvasId(519);

v8::Local<v8::Value> wrapper = toV8(canvas, scope.getScriptState());

Transferables transferables;

transferables.offscreenCanvases.append(canvas);

@@ -525,7 +525,7 @@ TEST(V8ScriptValueSerializerTest, TransferOffscreenCanvas) {

OffscreenCanvas* newCanvas =

V8OffscreenCanvas::toImpl(result.As<v8::Object>());

EXPECT_EQ(IntSize(10, 7), newCanvas->size());

- EXPECT_EQ(519, newCanvas->getAssociatedCanvasId());

+ EXPECT_EQ(519, newCanvas->placeholderCanvasId());

EXPECT_TRUE(canvas->isNeutered());

EXPECT_FALSE(newCanvas->isNeutered());

}