Issue 2493553002: Fix -Wsign-compare warnings in parser, scanner, regexp, runtime.

Issue 2493553002: Fix -Wsign-compare warnings in parser, scanner, regexp, runtime. (Closed)

Created:
4 years, 1 month ago by ulan

Modified:
4 years, 1 month ago

Reviewers:
yangguo, rossberg, Yang

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix -Wsign-compare warnings in parser, scanner, regexp, runtime. BUG=v8:5614 Committed: https://crrev.com/d5f22440a2aa4d4a1c3446b267352f47b690e15a Cr-Commit-Position: refs/heads/master@{#40892}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -25 lines)			Patch
M	src/ast/ast.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/base/cpu.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/builtins/builtins-regexp.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/builtins/builtins-string.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/libsampler/sampler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/parsing/scanner.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/regexp/regexp-parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime/runtime-i18n.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/runtime/runtime-regexp.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/uri.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/value-serializer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-code-stub-assembler.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/unittests/source-position-table-unittest.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 9 (3 generated)

ulan

Andreas, ptal at ast/* and parsing/*. Yang, ptal at the rest.

4 years, 1 month ago (2016-11-09 19:06:46 UTC) #2

Yang

On 2016/11/09 19:06:46, ulan wrote: > Andreas, ptal at ast/* and parsing/*. > > Yang, ...

4 years, 1 month ago (2016-11-10 10:40:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493553002/1

4 years, 1 month ago (2016-11-10 12:27:55 UTC) #6

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:29:10 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d5f22440a2aa4d4a1c3446b267352f47b690e15a
Cr-Commit-Position: refs/heads/master@{#40892}