src/uri.cc - Issue 2493553002: Fix -Wsign-compare warnings in parser, scanner, regexp, runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/uri.cc

Issue 2493553002: Fix -Wsign-compare warnings in parser, scanner, regexp, runtime. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/uri.cc

diff --git a/src/uri.cc b/src/uri.cc

index de7bd9bf57749af9286a3484e3c75858ec5498e9..14e22146e7b5799801b20ae6fb7d6d63432381fc 100644

--- a/src/uri.cc

+++ b/src/uri.cc

@@ -51,7 +51,7 @@ bool DecodeOctets(const uint8_t* octets, int length, List<uc16>* buffer) {

return false;

}

- if (value <= unibrow::Utf16::kMaxNonSurrogateCharCode) {

+ if (value <= static_cast<uc32>(unibrow::Utf16::kMaxNonSurrogateCharCode)) {

buffer->Add(value);

} else {

buffer->Add(unibrow::Utf16::LeadSurrogate(value));

« no previous file with comments | « src/runtime/runtime-regexp.cc ('k') | src/value-serializer.cc » ('j') | no next file with comments »