Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2493533002: Fix parsing of 'start' attribute of <ol> element (Closed)

Created:
4 years, 1 month ago by rwlbuis
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix parsing of 'start' attribute of <ol> element Fix parsing of 'start' attribute of <ol> element by using parseHTMLInteger instead of toInt. This also fixes the last remaining reflection-grouping.html failures. BUG=651762, 634796 Committed: https://crrev.com/d119af9ade51292737ff2c2730f5a14abed0004b Cr-Commit-Position: refs/heads/master@{#431495}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -141 lines) Patch
D third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-grouping-expected.txt View 1 1 chunk +0 lines, -139 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOListElement.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
rwlbuis
PTAL.
4 years, 1 month ago (2016-11-10 13:50:42 UTC) #3
tkent
lgtm. IMO, the CL summary should be something like "Fix parsing of 'start' attribute of ...
4 years, 1 month ago (2016-11-10 22:59:20 UTC) #5
rwlbuis
On 2016/11/10 22:59:20, tkent wrote: > lgtm. > > IMO, the CL summary should be ...
4 years, 1 month ago (2016-11-10 23:41:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493533002/20001
4 years, 1 month ago (2016-11-10 23:47:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/65684)
4 years, 1 month ago (2016-11-11 00:00:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2493533002/20001
4 years, 1 month ago (2016-11-11 01:59:18 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 04:26:29 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 05:16:17 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d119af9ade51292737ff2c2730f5a14abed0004b
Cr-Commit-Position: refs/heads/master@{#431495}

Powered by Google App Engine
This is Rietveld 408576698