Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: third_party/WebKit/Source/core/html/HTMLOListElement.cpp

Issue 2493533002: Fix parsing of 'start' attribute of <ol> element (Closed)
Patch Set: V2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-grouping-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLOListElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLOListElement.cpp b/third_party/WebKit/Source/core/html/HTMLOListElement.cpp
index c452564e0e280aafa85d12248565e97f5a340ed9..49dd5b86c2df8875aa842ce445a0fbbf63169e41 100644
--- a/third_party/WebKit/Source/core/html/HTMLOListElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLOListElement.cpp
@@ -25,6 +25,7 @@
#include "core/CSSPropertyNames.h"
#include "core/CSSValueKeywords.h"
#include "core/HTMLNames.h"
+#include "core/html/parser/HTMLParserIdioms.h"
#include "core/layout/LayoutListItem.h"
namespace blink {
@@ -78,8 +79,8 @@ void HTMLOListElement::parseAttribute(const QualifiedName& name,
const AtomicString& value) {
if (name == startAttr) {
int oldStart = start();
- bool canParse;
- int parsedStart = value.toInt(&canParse);
+ int parsedStart = 0;
+ bool canParse = parseHTMLInteger(value, parsedStart);
m_hasExplicitStart = canParse;
m_start = canParse ? parsedStart : 0xBADBEEF;
if (oldStart == start())
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/html/dom/reflection-grouping-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698