Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2493463002: Fix backspace double occuring on PDF files. (Closed)

Created:
4 years, 1 month ago by dtapuska
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix backspace double occuring on PDF files. For some reason I overlooked an ifdef I left in some code in change; https://chromium.googlesource.com/chromium/src/+/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d%5E%21/ Make sure this code isn't ifdef'd out since this is the easiest path to merge into M55. I've added a TODO to revisit this since I think this function can actually be removed and not generate the events in the first place. BUG=663002 Review-Url: https://codereview.chromium.org/2481943002 Cr-Commit-Position: refs/heads/master@{#430478} (cherry picked from commit 435a59e7bbcf2e5875f860317f1056d914a30610) Committed: https://chromium.googlesource.com/chromium/src/+/21ad4cf85b24053d7994ef0b234c658e4a64f058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/public/platform/WebInputEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 1 month ago (2016-11-09 14:21:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
21ad4cf85b24053d7994ef0b234c658e4a64f058.

Powered by Google App Engine
This is Rietveld 408576698