Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2481943002: Fix backspace double occuring on PDF files. (Closed)

Created:
4 years, 1 month ago by dtapuska
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix backspace double occuring on PDF files. For some reason I overlooked an ifdef I left in some code in change; https://chromium.googlesource.com/chromium/src/+/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d%5E%21/ Make sure this code isn't ifdef'd out since this is the easiest path to merge into M55. I've added a TODO to revisit this since I think this function can actually be removed and not generate the events in the first place. BUG=663002 Committed: https://crrev.com/435a59e7bbcf2e5875f860317f1056d914a30610 Cr-Commit-Position: refs/heads/master@{#430478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/public/platform/WebInputEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dtapuska
PTAL
4 years, 1 month ago (2016-11-07 20:54:21 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-08 00:44:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2481943002/1
4 years, 1 month ago (2016-11-08 00:52:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 02:10:01 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 02:13:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/435a59e7bbcf2e5875f860317f1056d914a30610
Cr-Commit-Position: refs/heads/master@{#430478}

Powered by Google App Engine
This is Rietveld 408576698