DBC: Fix checked mode stack traces

DBC: Fix checked mode stack traces

fixes #27732

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/a64272b91200627d576f0c7df05c59da73425489

[zra, 2016-11-11 23:45:55]

zra@google.com changed reviewers:
+ fschneider@google.com, rmacnak@google.com

[Florian Schneider, 2016-11-11 23:48:59]

Lgtm.

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler_dbc.cc (right):

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler_dbc.cc:265:
AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id, token_pos);
Is this descriptor still needed?

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:205:
compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(),
Still needed?

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:228:
compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(),
Same here.

[zra, 2016-11-12 05:29:03]

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler_dbc.cc (right):

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler_dbc.cc:265:
AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id, token_pos);
On 2016/11/11 23:48:59, Florian Schneider wrote:
> Is this descriptor still needed?

I believe so yes. For the other architectures as well, there are two descriptors
created in FlowGraphCompiler::GenerateRuntimeCall().

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:205:
compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(),
On 2016/11/11 23:48:59, Florian Schneider wrote:
> Still needed?

ditto

https://codereview.chromium.org/2493353002/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_dbc.cc:228:
compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(),
On 2016/11/11 23:48:59, Florian Schneider wrote:
> Same here.

ditto

[zra, 2016-11-12 05:39:50]

Description was changed from

==========
DBC: Fix checked mode stack traces

fixes #27732
==========

to

==========
DBC: Fix checked mode stack traces

fixes #27732

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a64272b91200627d576f0c7df05c59da73425489
==========

[zra, 2016-11-12 05:39:51]

Committed patchset #1 (id:1) manually as
a64272b91200627d576f0c7df05c59da73425489 (presubmit successful).