Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: runtime/vm/intermediate_language_dbc.cc

Issue 2493353002: DBC: Fix checked mode stack traces (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_dbc.cc
diff --git a/runtime/vm/intermediate_language_dbc.cc b/runtime/vm/intermediate_language_dbc.cc
index ababea8d202001755c9830b5c39135409b721a7e..207153d4b76931bf30cd873b088c9ccbb0b953f7 100644
--- a/runtime/vm/intermediate_language_dbc.cc
+++ b/runtime/vm/intermediate_language_dbc.cc
@@ -202,10 +202,9 @@ EMIT_NATIVE_CODE(InstanceOf,
__ PushConstant(type());
__ PushConstant(test_cache);
__ InstanceOf(negate_result() ? 1 : 0);
- compiler->RecordSafepoint(locs());
compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(),
Florian Schneider 2016/11/11 23:48:59 Still needed?
zra 2016/11/12 05:29:03 ditto
token_pos());
-
+ compiler->RecordAfterCall(this);
if (compiler->is_optimizing()) {
__ PopLocal(locs()->out(0).reg());
}
@@ -226,9 +225,9 @@ EMIT_NATIVE_CODE(AssertBoolean,
__ Push(locs()->in(0).reg());
}
__ AssertBoolean(Isolate::Current()->type_checks() ? 1 : 0);
- compiler->RecordSafepoint(locs());
compiler->AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id(),
Florian Schneider 2016/11/11 23:48:59 Same here.
zra 2016/11/12 05:29:03 ditto
token_pos());
+ compiler->RecordAfterCall(this);
if (compiler->is_optimizing()) {
__ Drop1();
}
« runtime/vm/flow_graph_compiler_dbc.cc ('K') | « runtime/vm/flow_graph_compiler_dbc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698