Remove legacy callers for HTMLEmbedElement and HTMLObjectElement

Remove legacy callers for HTMLEmbedElement and HTMLObjectElement

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/AiDZ7ru9mGg/_D_9Fcc2AwAJ

BUG=663662
Review-Url: https://codereview.chromium.org/2493343002
Cr-Commit-Position: refs/heads/master@{#450185}
Committed: https://chromium.googlesource.com/chromium/src/+/352682e3c9a3d4b9a6b2147e9b8573b449f71b37

[foolip, 2016-11-11 22:54:41]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 22:55:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-11-11 23:23:25]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 23:23:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 00:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 00:03:56]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[foolip, 2016-11-12 10:47:21]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-12 10:47:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-12 12:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-12 12:44:32]

Dry run: This issue passed the CQ dry run.

[foolip, 2016-11-14 19:43:47]

foolip@chromium.org changed reviewers:
+ dcheng@chromium.org

[foolip, 2016-11-14 19:43:48]

dcheng@, I'm writing an Intent to Deprecate and Remove for this, but there's
this in HTMLPlugInElement.h that I don't understand:

  // TODO(dcheng): Consider removing this, since HTMLEmbedElementLegacyCall
  // and HTMLObjectElementLegacyCall usage is extremely low.
  SharedPersistent<v8::Object>* pluginWrapper();

Removing the legacy callers is not enough to get rid of pluginWrapper(), but
getting rid of the named getters/setters would be. Is it as simple as a mistaken
TODO, or is there something more going on?

While I have your attention, do you understand if it's possible for the legacy
caller I'm removing to ever return anything other than undefined? Drilling down
into PepperWebPluginImpl::v8ScriptableObject and beyond I'm not really sure what
I'm looking for.

[dcheng, 2016-11-14 20:05:37]

On 2016/11/14 19:43:48, foolip wrote:
> dcheng@, I'm writing an Intent to Deprecate and Remove for this, but there's
> this in HTMLPlugInElement.h that I don't understand:
> 
>   // TODO(dcheng): Consider removing this, since HTMLEmbedElementLegacyCall
>   // and HTMLObjectElementLegacyCall usage is extremely low.
>   SharedPersistent<v8::Object>* pluginWrapper();
> 
> Removing the legacy callers is not enough to get rid of pluginWrapper(), but
> getting rid of the named getters/setters would be. Is it as simple as a
mistaken
> TODO, or is there something more going on?
> 

The TODO might not have covered everything. I think I added this TODO based on
things that failed to compile when I was removing NPAPI support.

> While I have your attention, do you understand if it's possible for the legacy
> caller I'm removing to ever return anything other than undefined? Drilling
down
> into PepperWebPluginImpl::v8ScriptableObject and beyond I'm not really sure
what
> I'm looking for.

I have the vague recollection that we kept it around to avoid breaking the
Hangout plugin, but I can't find anything in reviews that authoritatively state
that.

[foolip, 2016-11-21 09:45:36]

Description was changed from

==========
Drop legacycaller for HTMLEmbedElement and HTMLObjectElement

BUG=663662
==========

to

==========
Drop legacycaller for HTMLEmbedElement and HTMLObjectElement

BUG=663662
==========

[foolip, 2016-11-21 09:46:03]

This is now dprecated. Closing for now and may revive when the time to remove
comes.

[foolip, 2017-02-13 10:00:09]

Description was changed from

==========
Drop legacycaller for HTMLEmbedElement and HTMLObjectElement

BUG=663662
==========

to

==========
Remove legacy callers for HTMLEmbedElement and HTMLObjectElement

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/AiDZ7ru9mGg/_D_9Fcc2...

BUG=663662
==========

[foolip, 2017-02-13 11:40:00]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 11:40:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 13:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 13:33:06]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[foolip, 2017-02-13 16:18:49]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 16:19:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2017-02-13 17:23:25]

foolip@chromium.org changed reviewers:
+ tkent@chromium.org

[foolip, 2017-02-13 17:23:25]

tkent@, PTAL and CQ if the bots are happy this time :)

[commit-bot: I haz the power, 2017-02-13 18:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 18:09:40]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-13 23:33:57]

lgtm

[foolip, 2017-02-14 01:16:59]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:17:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 01:23:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487035019690590,
"parent_rev": "ecf5359e680e3e250b3317827fb0b1c774721f3c", "commit_rev":
"352682e3c9a3d4b9a6b2147e9b8573b449f71b37"}

[commit-bot: I haz the power, 2017-02-14 01:24:31]

Description was changed from

==========
Remove legacy callers for HTMLEmbedElement and HTMLObjectElement

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/AiDZ7ru9mGg/_D_9Fcc2...

BUG=663662
==========

to

==========
Remove legacy callers for HTMLEmbedElement and HTMLObjectElement

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/AiDZ7ru9mGg/_D_9Fcc2...

BUG=663662

Review-Url: https://codereview.chromium.org/2493343002
Cr-Commit-Position: refs/heads/master@{#450185}
Committed:
https://chromium.googlesource.com/chromium/src/+/352682e3c9a3d4b9a6b2147e9b85...
==========

[commit-bot: I haz the power, 2017-02-14 01:24:32]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/352682e3c9a3d4b9a6b2147e9b85...