[extensions] Stop parsing webstore urls so much

chrome/common/extensions/extension_constants.cc

Index: chrome/common/extensions/extension_constants.cc
diff --git a/chrome/common/extensions/extension_constants.cc b/chrome/common/extensions/extension_constants.cc
index 4e6df3c83a1e91b0ba21391e13712fe417cd096a..fc412ba60e70392295408b3dd9ca0d537ebb9ad1 100644
--- a/chrome/common/extensions/extension_constants.cc
+++ b/chrome/common/extensions/extension_constants.cc
@@ -15,8 +15,8 @@ const char kGalleryUpdateHttpsUrl[] =
 
 }  // namespace
 
-GURL GetDefaultWebstoreUpdateUrl() {
-  return GURL(kGalleryUpdateHttpsUrl);
+std::string GetDefaultWebstoreUpdateUrl() {

[Devlin, 2016/11/11 23:11:31]

Why std::string instead of const char*?  Most callers will probably construct an
url or do comparison, both of which can use a stringpiece.

[Charlie Harrison, 2016/11/12 02:24:34]

Good catch. Done.

+  return kGalleryUpdateHttpsUrl;
 }
 
 const char kWebstoreSourceField[] = "utm_source";