[extensions] Stop parsing webstore urls so much

chrome/common/extensions/extension_constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/common/extensions/extension_constants.h"
 
 namespace extension_urls {
 
 namespace {
 
 const char kGalleryUpdateHttpsUrl[] =
     "https://clients2.google.com/service/update2/crx";
 
 }  // namespace
 
-GURL GetDefaultWebstoreUpdateUrl() {
-  return GURL(kGalleryUpdateHttpsUrl);
+std::string GetDefaultWebstoreUpdateUrl() {

[Devlin, 2016/11/11 23:11:31]

Why std::string instead of const char*?  Most callers will probably construct an
url or do comparison, both of which can use a stringpiece.

[Charlie Harrison, 2016/11/12 02:24:34]

Good catch. Done.

+  return kGalleryUpdateHttpsUrl;
 }
 
 const char kWebstoreSourceField[] = "utm_source";
 
 const char kLaunchSourceAppList[] = "chrome-app-launcher";
 const char kLaunchSourceAppListSearch[] = "chrome-app-launcher-search";
 const char kLaunchSourceAppListInfoDialog[] = "chrome-app-launcher-info-dialog";
 
 }  // namespace extension_urls
 
@@ skipping 72 matching lines @@
   const char* const kImeMenuExtensionIds[] = {
       "gjaehgfemfahhmlgpdfknkhdnemmolop", "jkghodnilhceideoidjikpgommlajknk"};
   for (const char* id : kImeMenuExtensionIds) {
     if (extension_id == id)
       return true;
   }
   return false;
 }
 #endif
 }  // namespace extension_misc