Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2492953002: Support more specific descriptors of a machine's OS in Machine Provider dimensions (Closed)

Created:
4 years, 1 month ago by smut
Modified:
4 years, 1 month ago
Reviewers:
Vadim Sh., hinoka
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Support more specific descriptors of a machine's OS in Machine Provider dimensions BUG=664296 Committed: https://github.com/luci/luci-py/commit/6996ed6741701ed5d69a62ccc0b52c5c9cd61830

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M appengine/components/components/machine_provider/dimensions.py View 2 chunks +9 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
smut
4 years, 1 month ago (2016-11-10 23:15:41 UTC) #2
Vadim Sh.
https://codereview.chromium.org/2492953002/diff/1/appengine/components/components/machine_provider/dimensions.py File appengine/components/components/machine_provider/dimensions.py (right): https://codereview.chromium.org/2492953002/diff/1/appengine/components/components/machine_provider/dimensions.py#newcode46 appengine/components/components/machine_provider/dimensions.py:46: linux_flavor = messages.EnumField(LinuxFlavor, 7) is there an advantage of ...
4 years, 1 month ago (2016-11-10 23:37:08 UTC) #3
smut
https://codereview.chromium.org/2492953002/diff/1/appengine/components/components/machine_provider/dimensions.py File appengine/components/components/machine_provider/dimensions.py (right): https://codereview.chromium.org/2492953002/diff/1/appengine/components/components/machine_provider/dimensions.py#newcode46 appengine/components/components/machine_provider/dimensions.py:46: linux_flavor = messages.EnumField(LinuxFlavor, 7) On 2016/11/10 23:37:08, Vadim Sh. ...
4 years, 1 month ago (2016-11-11 00:14:14 UTC) #4
Vadim Sh.
whatever, I have no strong opinion either way :) lgtm
4 years, 1 month ago (2016-11-11 00:16:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492953002/1
4 years, 1 month ago (2016-11-11 22:02:41 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 22:05:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/6996ed6741701ed5d69a62ccc0b52c5c9cd61830

Powered by Google App Engine
This is Rietveld 408576698