Support more specific descriptors of a machine's OS in Machine Provider dimensions

Support more specific descriptors of a machine's OS in Machine Provider dimensions

BUG=664296
Committed: https://github.com/luci/luci-py/commit/6996ed6741701ed5d69a62ccc0b52c5c9cd61830

[smut, 2016-11-10 23:15:41]

smut@google.com changed reviewers:
+ hinoka@chromium.org, vadimsh@chromium.org

[Vadim Sh., 2016-11-10 23:37:08]

https://codereview.chromium.org/2492953002/diff/1/appengine/components/compon...
File appengine/components/components/machine_provider/dimensions.py (right):

https://codereview.chromium.org/2492953002/diff/1/appengine/components/compon...
appengine/components/components/machine_provider/dimensions.py:46: linux_flavor
= messages.EnumField(LinuxFlavor, 7)
is there an advantage of having this separate instead of putting it into
os_version?

E.g. make os_version be "ubuntu-14.04"

[smut, 2016-11-11 00:14:14]

https://codereview.chromium.org/2492953002/diff/1/appengine/components/compon...
File appengine/components/components/machine_provider/dimensions.py (right):

https://codereview.chromium.org/2492953002/diff/1/appengine/components/compon...
appengine/components/components/machine_provider/dimensions.py:46: linux_flavor
= messages.EnumField(LinuxFlavor, 7)
On 2016/11/10 23:37:08, Vadim Sh. wrote:
> is there an advantage of having this separate instead of putting it into
> os_version?
> 
> E.g. make os_version be "ubuntu-14.04"

I have no strong feelings one way or the other.

I just did it this way because Swarming reports increasing specificity for Linux
this way, e.g. os: Linux | Ubuntu | Ubuntu-14.04 and because the user has less
to screw up in luci-config (e.g. capitalization: "Ubuntu-14.04" vs.
"ubuntu-14.04").

[Vadim Sh., 2016-11-11 00:16:28]

whatever, I have no strong opinion either way :) 

lgtm

[smut, 2016-11-11 22:02:36]

The CQ bit was checked by smut@google.com

[commit-bot: I haz the power, 2016-11-11 22:02:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 22:05:34]

Description was changed from

==========
Support more specific descriptors of a machine's OS in Machine Provider
dimensions

BUG=664296
==========

to

==========
Support more specific descriptors of a machine's OS in Machine Provider
dimensions

BUG=664296

Committed:
https://github.com/luci/luci-py/commit/6996ed6741701ed5d69a62ccc0b52c5c9cd61830
==========

[commit-bot: I haz the power, 2016-11-11 22:05:37]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/6996ed6741701ed5d69a62ccc0b52c5c9cd61830