Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2248)

Unified Diff: appengine/components/components/machine_provider/dimensions.py

Issue 2492953002: Support more specific descriptors of a machine's OS in Machine Provider dimensions (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/components/components/machine_provider/dimensions.py
diff --git a/appengine/components/components/machine_provider/dimensions.py b/appengine/components/components/machine_provider/dimensions.py
index ed1fd194da5a1fe9d414d678c04b9e15aa001b67..9eb0a5814876b5ef3dd08ec6291c1ddd4c18d3df 100644
--- a/appengine/components/components/machine_provider/dimensions.py
+++ b/appengine/components/components/machine_provider/dimensions.py
@@ -21,6 +21,11 @@ class OSFamily(messages.Enum):
WINDOWS = 3
+class LinuxFlavor(messages.Enum):
+ """Lists valid flavors of Linux."""
+ UBUNTU = 1
+
+
class Dimensions(messages.Message):
"""Represents the dimensions of a machine."""
# The operating system family of this machine.
@@ -37,3 +42,7 @@ class Dimensions(messages.Message):
memory_gb = messages.FloatField(5)
# The disk space available to this machine.
disk_gb = messages.IntegerField(6)
+ # The flavor of Linux of this machine.
+ linux_flavor = messages.EnumField(LinuxFlavor, 7)
Vadim Sh. 2016/11/10 23:37:08 is there an advantage of having this separate inst
smut 2016/11/11 00:14:14 I have no strong feelings one way or the other. I
+ # The operating system version of this machine.
+ os_version = messages.StringField(8)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698