Print console warnings when MediaSession message is dirty

Print console warnings when MediaSession message is dirty

BUG=625244
TEST=MANUAL

Committed: https://crrev.com/e125f89dbe38c925a96cbc905dcd18b7f31deb20
Cr-Commit-Position: refs/heads/master@{#431673}

[Zhiqiang Zhang (Slow), 2016-11-10 17:37:02]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org

[Zhiqiang Zhang (Slow), 2016-11-10 17:37:03]

PTAL

I'm supposing we don't need layout tests for console warnings.

[whywhat, 2016-11-11 20:09:02]

lgtm

https://codereview.chromium.org/2492823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp
(right):

https://codereview.chromium.org/2492823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp:37: //
Console warning for invalid src is printed upon MediaImage creation.
Do we want to do that? Maybe it's better to show the warning when the invalid
src is used?

[Zhiqiang Zhang (Slow), 2016-11-11 20:56:44]

https://codereview.chromium.org/2492823003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp
(right):

https://codereview.chromium.org/2492823003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediasession/MediaMetadataSanitizer.cpp:37: //
Console warning for invalid src is printed upon MediaImage creation.
On 2016/11/11 20:09:02, whywhat wrote:
> Do we want to do that? Maybe it's better to show the warning when the invalid
> src is used?

Invalid src is dropped when passing metadata through mojo, so we need to print a
warning before passing it through mojo.

I tried to to print the warning here, but the original src in MediaImageInit is
already lost at this point, thus src is empty. So the developer may wonder which
src is wrong.

[Zhiqiang Zhang (Slow), 2016-11-11 20:56:56]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:57:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 22:36:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-11 22:44:34]

Description was changed from

==========
Print console warnings when MediaSession message is dirty

BUG=625244
TEST=MANUAL
==========

to

==========
Print console warnings when MediaSession message is dirty

BUG=625244
TEST=MANUAL

Committed: https://crrev.com/e125f89dbe38c925a96cbc905dcd18b7f31deb20
Cr-Commit-Position: refs/heads/master@{#431673}
==========

[commit-bot: I haz the power, 2016-11-11 22:44:35]

Patchset 2 (id:??) landed as
https://crrev.com/e125f89dbe38c925a96cbc905dcd18b7f31deb20
Cr-Commit-Position: refs/heads/master@{#431673}