Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: third_party/WebKit/Source/modules/mediasession/MediaImage.cpp

Issue 2492823003: Print console warnings when MediaSession message is dirty (Closed)
Patch Set: nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediasession/MediaImage.cpp
diff --git a/third_party/WebKit/Source/modules/mediasession/MediaImage.cpp b/third_party/WebKit/Source/modules/mediasession/MediaImage.cpp
index ebad13eb9396eced1ab0848d7ed0d8cb162c9e05..c2e08e9f368cc3cae0bc3acd3b0add1f2db8161b 100644
--- a/third_party/WebKit/Source/modules/mediasession/MediaImage.cpp
+++ b/third_party/WebKit/Source/modules/mediasession/MediaImage.cpp
@@ -5,7 +5,10 @@
#include "modules/mediasession/MediaImage.h"
#include "core/dom/ExecutionContext.h"
+#include "core/inspector/ConsoleMessage.h"
#include "modules/mediasession/MediaImageInit.h"
+#include "platform/weborigin/KURL.h"
+#include "wtf/text/StringOperators.h"
namespace blink {
@@ -17,6 +20,11 @@ MediaImage* MediaImage::create(ExecutionContext* context,
MediaImage::MediaImage(ExecutionContext* context, const MediaImageInit& image) {
m_src = context->completeURL(image.src());
+ if (!KURL(ParsedURLString, m_src).isValid()) {
+ context->addConsoleMessage(
+ ConsoleMessage::create(JSMessageSource, WarningMessageLevel,
+ "MediaImage src is invalid: " + image.src()));
+ }
m_sizes = image.sizes();
m_type = image.type();
}

Powered by Google App Engine
This is Rietveld 408576698