Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2492803002: PPC/s390: Fix FullCodeGen to include CallICs and CallConstruct in the total ic count. (Closed)

Created:
4 years, 1 month ago by JaideepBajwa
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: Fix FullCodeGen to include CallICs and CallConstruct in the total ic count. Port 832439ab8f2aa933b6c3dc63aa7305bb5e803718 Original commit message: FullCodeGen does not include CallICs in the total ic count. Fix it by making calls to CallIC to go through CallIC function, which keeps track of the total number of ICs. R=mythria@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Committed: https://crrev.com/6f4464ecb6df294f35c7f1b37c830c9b91e49c46 Cr-Commit-Position: refs/heads/master@{#40899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
ptal
4 years, 1 month ago (2016-11-10 14:16:09 UTC) #1
john.yan
lgtm
4 years, 1 month ago (2016-11-10 14:18:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492803002/1
4 years, 1 month ago (2016-11-10 14:20:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 14:45:00 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:29:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f4464ecb6df294f35c7f1b37c830c9b91e49c46
Cr-Commit-Position: refs/heads/master@{#40899}

Powered by Google App Engine
This is Rietveld 408576698