Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: src/full-codegen/ppc/full-codegen-ppc.cc

Issue 2492803002: PPC/s390: Fix FullCodeGen to include CallICs and CallConstruct in the total ic count. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/full-codegen/s390/full-codegen-s390.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2375 matching lines...) Expand 10 before | Expand all | Expand 10 after
2386 } 2386 }
2387 // Update profiling counters before the tail call since we will 2387 // Update profiling counters before the tail call since we will
2388 // not return to this function. 2388 // not return to this function.
2389 EmitProfilingCounterHandlingForReturnSequence(true); 2389 EmitProfilingCounterHandlingForReturnSequence(true);
2390 } 2390 }
2391 Handle<Code> code = 2391 Handle<Code> code =
2392 CodeFactory::CallIC(isolate(), mode, expr->tail_call_mode()).code(); 2392 CodeFactory::CallIC(isolate(), mode, expr->tail_call_mode()).code();
2393 __ LoadSmiLiteral(r6, SmiFromSlot(expr->CallFeedbackICSlot())); 2393 __ LoadSmiLiteral(r6, SmiFromSlot(expr->CallFeedbackICSlot()));
2394 __ LoadP(r4, MemOperand(sp, (arg_count + 1) * kPointerSize), r0); 2394 __ LoadP(r4, MemOperand(sp, (arg_count + 1) * kPointerSize), r0);
2395 __ mov(r3, Operand(arg_count)); 2395 __ mov(r3, Operand(arg_count));
2396 __ Call(code, RelocInfo::CODE_TARGET); 2396 CallIC(code);
2397 OperandStackDepthDecrement(arg_count + 1); 2397 OperandStackDepthDecrement(arg_count + 1);
2398 2398
2399 RecordJSReturnSite(expr); 2399 RecordJSReturnSite(expr);
2400 RestoreContext(); 2400 RestoreContext();
2401 context()->DropAndPlug(1, r3); 2401 context()->DropAndPlug(1, r3);
2402 } 2402 }
2403 2403
2404 2404
2405 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) { 2405 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) {
2406 int arg_count = expr->arguments()->length(); 2406 int arg_count = expr->arguments()->length();
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
2537 2537
2538 // Load function and argument count into r4 and r3. 2538 // Load function and argument count into r4 and r3.
2539 __ mov(r3, Operand(arg_count)); 2539 __ mov(r3, Operand(arg_count));
2540 __ LoadP(r4, MemOperand(sp, arg_count * kPointerSize), r0); 2540 __ LoadP(r4, MemOperand(sp, arg_count * kPointerSize), r0);
2541 2541
2542 // Record call targets in unoptimized code. 2542 // Record call targets in unoptimized code.
2543 __ EmitLoadTypeFeedbackVector(r5); 2543 __ EmitLoadTypeFeedbackVector(r5);
2544 __ LoadSmiLiteral(r6, SmiFromSlot(expr->CallNewFeedbackSlot())); 2544 __ LoadSmiLiteral(r6, SmiFromSlot(expr->CallNewFeedbackSlot()));
2545 2545
2546 CallConstructStub stub(isolate()); 2546 CallConstructStub stub(isolate());
2547 __ Call(stub.GetCode(), RelocInfo::CODE_TARGET); 2547 CallIC(stub.GetCode());
2548 OperandStackDepthDecrement(arg_count + 1); 2548 OperandStackDepthDecrement(arg_count + 1);
2549 PrepareForBailoutForId(expr->ReturnId(), BailoutState::TOS_REGISTER); 2549 PrepareForBailoutForId(expr->ReturnId(), BailoutState::TOS_REGISTER);
2550 RestoreContext(); 2550 RestoreContext();
2551 context()->Plug(r3); 2551 context()->Plug(r3);
2552 } 2552 }
2553 2553
2554 2554
2555 void FullCodeGenerator::EmitSuperConstructorCall(Call* expr) { 2555 void FullCodeGenerator::EmitSuperConstructorCall(Call* expr) {
2556 SuperCallReference* super_call_ref = 2556 SuperCallReference* super_call_ref =
2557 expr->expression()->AsSuperCallReference(); 2557 expr->expression()->AsSuperCallReference();
(...skipping 1066 matching lines...) Expand 10 before | Expand all | Expand 10 after
3624 3624
3625 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address))); 3625 DCHECK(Assembler::IsCrSet(Assembler::instr_at(cmp_address)));
3626 3626
3627 DCHECK(interrupt_address == 3627 DCHECK(interrupt_address ==
3628 isolate->builtins()->OnStackReplacement()->entry()); 3628 isolate->builtins()->OnStackReplacement()->entry());
3629 return ON_STACK_REPLACEMENT; 3629 return ON_STACK_REPLACEMENT;
3630 } 3630 }
3631 } // namespace internal 3631 } // namespace internal
3632 } // namespace v8 3632 } // namespace v8
3633 #endif // V8_TARGET_ARCH_PPC 3633 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « no previous file | src/full-codegen/s390/full-codegen-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698