Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2492783002: Skip independent inherited property propagation to pseudo elements. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
Reviewers:
sashab
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip independent inherited property propagation to pseudo elements. UpdatePseudoElements and IndependentInherit conflict in the following way. If we both have an independent inherit change on the actual dom element, and we detect that we need to update the style for the pseudo element we need to signal the inheritance propagation to the real dom children and signal the pseudo element recalc to the pseudo element children. If we return IndependentInherit, we lose the information about the need for a pseudo element recalc, and if we return UpdatePseudoElement, we lose the inheritance propagation for the actual dom children. We could introduce a new IndependentInheritAndUpdatePseudoElements, but if there exists pseudo element, we would always return this constant, so instead just force recalc on pseudo elements on IndependentInherit. R=sashab@chromium.org BUG=660735, 660089, 657283 Committed: https://crrev.com/998f4790884a34c5ac5167876a13b7cb7495a617 Cr-Commit-Position: refs/heads/master@{#431430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/independent-inherit-update-pseudo.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 1 month ago (2016-11-10 09:56:50 UTC) #3
sashab
LGTM! :D
4 years, 1 month ago (2016-11-10 23:28:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492783002/1
4 years, 1 month ago (2016-11-10 23:47:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 00:51:08 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 00:56:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/998f4790884a34c5ac5167876a13b7cb7495a617
Cr-Commit-Position: refs/heads/master@{#431430}

Powered by Google App Engine
This is Rietveld 408576698