Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2492783002: Skip independent inherited property propagation to pseudo elements. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/independent-inherit-update-pseudo.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 1884 matching lines...) Expand 10 before | Expand all | Expand 10 after
1895 } 1895 }
1896 1896
1897 if (hasCustomStyleCallbacks()) 1897 if (hasCustomStyleCallbacks())
1898 didRecalcStyle(change); 1898 didRecalcStyle(change);
1899 } 1899 }
1900 1900
1901 PassRefPtr<ComputedStyle> Element::propagateInheritedProperties( 1901 PassRefPtr<ComputedStyle> Element::propagateInheritedProperties(
1902 StyleRecalcChange change) { 1902 StyleRecalcChange change) {
1903 if (change != IndependentInherit) 1903 if (change != IndependentInherit)
1904 return nullptr; 1904 return nullptr;
1905 if (isPseudoElement())
1906 return nullptr;
1905 if (needsStyleRecalc()) 1907 if (needsStyleRecalc())
1906 return nullptr; 1908 return nullptr;
1907 if (hasAnimations()) 1909 if (hasAnimations())
1908 return nullptr; 1910 return nullptr;
1909 const ComputedStyle* parentStyle = parentComputedStyle(); 1911 const ComputedStyle* parentStyle = parentComputedStyle();
1910 DCHECK(parentStyle); 1912 DCHECK(parentStyle);
1911 const ComputedStyle* style = computedStyle(); 1913 const ComputedStyle* style = computedStyle();
1912 if (!style || style->animations() || style->transitions()) 1914 if (!style || style->animations() || style->transitions())
1913 return nullptr; 1915 return nullptr;
1914 RefPtr<ComputedStyle> newStyle = ComputedStyle::clone(*style); 1916 RefPtr<ComputedStyle> newStyle = ComputedStyle::clone(*style);
(...skipping 2173 matching lines...) Expand 10 before | Expand all | Expand 10 after
4088 } 4090 }
4089 4091
4090 DEFINE_TRACE_WRAPPERS(Element) { 4092 DEFINE_TRACE_WRAPPERS(Element) {
4091 if (hasRareData()) { 4093 if (hasRareData()) {
4092 visitor->traceWrappers(elementRareData()); 4094 visitor->traceWrappers(elementRareData());
4093 } 4095 }
4094 ContainerNode::traceWrappers(visitor); 4096 ContainerNode::traceWrappers(visitor);
4095 } 4097 }
4096 4098
4097 } // namespace blink 4099 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/independent-inherit-update-pseudo.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698