Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2492713005: [debugger] do not use asm validator for debug code. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] do not use asm validator for debug code. R=titzer@chromium.org Committed: https://crrev.com/70bedcb1efafce7782d8edac9c74faa502470a83 Cr-Commit-Position: refs/heads/master@{#40934}

Patch Set 1 #

Patch Set 2 : update test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/inspector/debugger/asm-js-breakpoint-before-exec-expected.txt View 1 1 chunk +36 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Yang
4 years, 1 month ago (2016-11-11 09:19:49 UTC) #1
Yang
On 2016/11/11 09:19:49, Yang wrote: ping. this is blocking https://codereview.chromium.org/2494043002/
4 years, 1 month ago (2016-11-11 15:03:16 UTC) #10
titzer
lgtm (sorry, it was all red when I first looked)
4 years, 1 month ago (2016-11-11 15:09:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2492713005/20001
4 years, 1 month ago (2016-11-11 15:10:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-11 15:12:53 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:31:06 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/70bedcb1efafce7782d8edac9c74faa502470a83
Cr-Commit-Position: refs/heads/master@{#40934}

Powered by Google App Engine
This is Rietveld 408576698