src/compiler.cc - Issue 2492713005: [debugger] do not use asm validator for debug code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 2492713005: [debugger] do not use asm validator for debug code. (Closed)

Patch Set: update test expectation Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 05ca9bb349757fa9d1759d2112209c91bdd69e9c..a143edc50467c3239327d26293125449511d91bf 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -415,7 +415,7 @@ CompilationJob::Status FinalizeUnoptimizedCompilationJob(CompilationJob* job) {

bool GenerateUnoptimizedCode(CompilationInfo* info) {

if (FLAG_validate_asm && info->scope()->asm_module() &&

- !info->shared_info()->is_asm_wasm_broken()) {

+ !info->shared_info()->is_asm_wasm_broken() && !info->is_debug()) {

EnsureFeedbackMetadata(info);

MaybeHandle<FixedArray> wasm_data;

wasm_data = AsmJs::ConvertAsmToWasm(info->parse_info());

« no previous file with comments | « no previous file | test/inspector/debugger/asm-js-breakpoint-before-exec-expected.txt » ('j') | no next file with comments »